Re: [Qemu-devel] [PATCH v3] net.c: Moved large array in nc_sendv_compat from the stack to the heap

On 14/03/2016 16:32, Eric Blake wrote: >> +const size_t STACKBUF_SIZE = 2048; >> + >> +uint8_t *buffer, *dynbuf = NULL; >> +uint8_t stackbuf[STACKBUF_SIZE]; Instead of using the "STACKBUF_SIZE" constant, you can use just "stackbuf[2048]", and then use sizeof(stackbuf) below. This

Re: [Qemu-devel] [PATCH v3] net.c: Moved large array in nc_sendv_compat from the stack to the heap

On 03/14/2016 06:46 AM, Nikos Filippakis wrote: > Allocate array in nc_sendv_compat on the heap if it is large to reduce stack > frame size, as stated in the BiteSizedTasks wiki page. Please wrap your commit messages at 70 or so columns (since 'git log' will display your text with indentation,

[Qemu-devel] [PATCH v3] net.c: Moved large array in nc_sendv_compat from the stack to the heap

Allocate array in nc_sendv_compat on the heap if it is large to reduce stack frame size, as stated in the BiteSizedTasks wiki page. Signed-off-by: Nikos Filippakis --- net/net.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff