Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread Christian Borntraeger
On 07/03/2017 01:48 PM, Viktor Mihajlovski wrote: > The response for query-cpu-definitions didn't include the > unavailable-features field, which is used by libvirt to figure > out whether a certain cpu model is usable on the host. > > The unavailable features are now computed by obtaining the

Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread Viktor Mihajlovski
On 04.07.2017 13:22, Viktor Mihajlovski wrote: > On 04.07.2017 11:35, David Hildenbrand wrote: >>> + >>> static void create_cpu_model_list(ObjectClass *klass, void *opaque) >>> { >>> -CpuDefinitionInfoList **cpu_list = opaque; >>> +struct CpuDefinitionInfoListData *cpu_list_data =

Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread Viktor Mihajlovski
On 04.07.2017 11:35, David Hildenbrand wrote: >> + >> static void create_cpu_model_list(ObjectClass *klass, void *opaque) >> { >> -CpuDefinitionInfoList **cpu_list = opaque; >> +struct CpuDefinitionInfoListData *cpu_list_data = opaque; >> +CpuDefinitionInfoList **cpu_list =

Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread Christian Borntraeger
On 07/04/2017 11:35 AM, David Hildenbrand wrote: >> + >> static void create_cpu_model_list(ObjectClass *klass, void *opaque) >> { >> -CpuDefinitionInfoList **cpu_list = opaque; >> +struct CpuDefinitionInfoListData *cpu_list_data = opaque; >> +CpuDefinitionInfoList **cpu_list =

Re: [Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-04 Thread David Hildenbrand
> + > static void create_cpu_model_list(ObjectClass *klass, void *opaque) > { > -CpuDefinitionInfoList **cpu_list = opaque; > +struct CpuDefinitionInfoListData *cpu_list_data = opaque; > +CpuDefinitionInfoList **cpu_list = _list_data->list; > CpuDefinitionInfoList *entry; >

[Qemu-devel] [PATCH v3] s390: return unavailable features via query-cpu-definitions

2017-07-03 Thread Viktor Mihajlovski
The response for query-cpu-definitions didn't include the unavailable-features field, which is used by libvirt to figure out whether a certain cpu model is usable on the host. The unavailable features are now computed by obtaining the host CPU model and comparing it against the known CPU models.