Re: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging
Gentle ping. This should be fairly easy to review, I hope; the worst of it is making sure that no tests remain that don't engage an entry point in iotests.py anymore. On 8/20/19 7:52 PM, John Snow wrote: > This series uses python logging to enable output conditionally on > iotests.log(). We unify an initialization call (which also enables > debugging output for those tests with -d) and then make the switch > inside of iotests. > > It will help alleviate the need to create logged/unlogged versions > of all the various helpers we have made. > > V3: > - Rebased for 4.1+; now based on main branch. > > V2: > - Added all of the other python tests I missed to use script_initialize > - Refactored the common setup as per Ehabkost's suggestion > - Added protocol arguments to common initialization, >but this isn't strictly required. > > John Snow (4): > iotests: add script_initialize > iotest 258: use script_main > iotests: add protocol support to initialization info > iotests: use python logging for iotests.log() > > tests/qemu-iotests/030| 4 +- > tests/qemu-iotests/149| 3 +- > tests/qemu-iotests/194| 3 +- > tests/qemu-iotests/202| 3 +- > tests/qemu-iotests/203| 3 +- > tests/qemu-iotests/206| 2 +- > tests/qemu-iotests/207| 4 +- > tests/qemu-iotests/208| 2 +- > tests/qemu-iotests/209| 2 +- > tests/qemu-iotests/210| 4 +- > tests/qemu-iotests/211| 4 +- > tests/qemu-iotests/212| 4 +- > tests/qemu-iotests/213| 4 +- > tests/qemu-iotests/216| 3 +- > tests/qemu-iotests/218| 2 +- > tests/qemu-iotests/219| 2 +- > tests/qemu-iotests/222| 5 +- > tests/qemu-iotests/224| 3 +- > tests/qemu-iotests/228| 3 +- > tests/qemu-iotests/234| 3 +- > tests/qemu-iotests/235| 4 +- > tests/qemu-iotests/236| 2 +- > tests/qemu-iotests/237| 2 +- > tests/qemu-iotests/238| 2 + > tests/qemu-iotests/242| 2 +- > tests/qemu-iotests/245| 1 + > tests/qemu-iotests/245.out| 24 > tests/qemu-iotests/246| 2 +- > tests/qemu-iotests/248| 2 +- > tests/qemu-iotests/254| 2 +- > tests/qemu-iotests/255| 2 +- > tests/qemu-iotests/256| 2 +- > tests/qemu-iotests/258| 8 +-- > tests/qemu-iotests/262| 3 +- > tests/qemu-iotests/iotests.py | 108 ++ > 35 files changed, 124 insertions(+), 105 deletions(-) >
Re: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging
On 8/20/19 8:10 PM, no-re...@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190820235243.26092-1-js...@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging > Message-id: 20190820235243.26092-1-js...@redhat.com > I have to remember that apparently git-publish does not seem to "save" my setting for adding my signed-off-by if I don't explicitly request it. Sorry about that. You may assume: Signed-off-by: John Snow for all patches in this series.
Re: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging
Patchew URL: https://patchew.org/QEMU/20190820235243.26092-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v3 0/4] iotests: use python logging Message-id: 20190820235243.26092-1-js...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20190820235243.26092-1-js...@redhat.com -> patchew/20190820235243.26092-1-js...@redhat.com Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/edk2' (https://git.qemu.org/git/edk2.git) registered for path 'roms/edk2' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/opensbi' (https://git.qemu.org/git/opensbi.git) registered for path 'roms/opensbi' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://git.qemu.org/git/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'slirp' (https://git.qemu.org/git/libslirp.git) registered for path 'slirp' Submodule 'tests/fp/berkeley-softfloat-3' (https://git.qemu.org/git/berkeley-softfloat-3.git) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://git.qemu.org/git/berkeley-testfloat-3.git) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out 'ba1ab360eebe6338bb8d7d83a9220ccf7e213af3' Cloning into 'roms/edk2'... Submodule path 'roms/edk2': checked out '20d2e5a125e34fc8501026613a71549b2a1a3e54' Submodule 'SoftFloat' (https://github.com/ucb-bar/berkeley-softfloat-3.git) registered for path 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3' Submodule 'CryptoPkg/Library/OpensslLib/openssl' (https://github.com/openssl/openssl) registered for path 'CryptoPkg/Library/OpensslLib/openssl' Cloning into 'ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3'... Submodule path 'roms/edk2/ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'CryptoPkg/Library/OpensslLib/openssl'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl': checked out '50eaac9f3337667259de725451f201e784599687' Submodule 'boringssl' (https://boringssl.googlesource.com/boringssl) registered for path 'boringssl' Submodule 'krb5' (https://github.com/krb5/krb5) registered for path 'krb5' Submodule 'pyca.cryptography' (https://github.com/pyca/cryptography.git) registered for path 'pyca-cryptography' Cloning into 'boringssl'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/boringssl': checked out '2070f8ad9151dc8f3a73bffaa146b5e6937a583f' Cloning into 'krb5'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/krb5': checked out 'b9ad6c49505c96a088326b62a52568e3484f2168' Cloning into 'pyca-cryptography'... Submodule path 'roms/edk2/CryptoPkg/Library/OpensslLib/openssl/pyca-cryptography': checked out '09403100de2f6f1cdd0d484dcb8e620f1c335c8f' Cloning into 'roms/ipxe'... Submodule path 'rom
[Qemu-devel] [PATCH v3 0/4] iotests: use python logging
This series uses python logging to enable output conditionally on iotests.log(). We unify an initialization call (which also enables debugging output for those tests with -d) and then make the switch inside of iotests. It will help alleviate the need to create logged/unlogged versions of all the various helpers we have made. V3: - Rebased for 4.1+; now based on main branch. V2: - Added all of the other python tests I missed to use script_initialize - Refactored the common setup as per Ehabkost's suggestion - Added protocol arguments to common initialization, but this isn't strictly required. John Snow (4): iotests: add script_initialize iotest 258: use script_main iotests: add protocol support to initialization info iotests: use python logging for iotests.log() tests/qemu-iotests/030| 4 +- tests/qemu-iotests/149| 3 +- tests/qemu-iotests/194| 3 +- tests/qemu-iotests/202| 3 +- tests/qemu-iotests/203| 3 +- tests/qemu-iotests/206| 2 +- tests/qemu-iotests/207| 4 +- tests/qemu-iotests/208| 2 +- tests/qemu-iotests/209| 2 +- tests/qemu-iotests/210| 4 +- tests/qemu-iotests/211| 4 +- tests/qemu-iotests/212| 4 +- tests/qemu-iotests/213| 4 +- tests/qemu-iotests/216| 3 +- tests/qemu-iotests/218| 2 +- tests/qemu-iotests/219| 2 +- tests/qemu-iotests/222| 5 +- tests/qemu-iotests/224| 3 +- tests/qemu-iotests/228| 3 +- tests/qemu-iotests/234| 3 +- tests/qemu-iotests/235| 4 +- tests/qemu-iotests/236| 2 +- tests/qemu-iotests/237| 2 +- tests/qemu-iotests/238| 2 + tests/qemu-iotests/242| 2 +- tests/qemu-iotests/245| 1 + tests/qemu-iotests/245.out| 24 tests/qemu-iotests/246| 2 +- tests/qemu-iotests/248| 2 +- tests/qemu-iotests/254| 2 +- tests/qemu-iotests/255| 2 +- tests/qemu-iotests/256| 2 +- tests/qemu-iotests/258| 8 +-- tests/qemu-iotests/262| 3 +- tests/qemu-iotests/iotests.py | 108 ++ 35 files changed, 124 insertions(+), 105 deletions(-) -- 2.21.0
