Re: [Qemu-devel] [PATCH v3 01/12] intel-iommu: send PSI always even if across PDEs

2018-05-18 Thread Auger Eric
Hi Peter, On 05/17/2018 10:59 AM, Peter Xu wrote: > During IOVA page table walking, there is a special case when the PSI > covers one whole PDE (Page Directory Entry, which contains 512 Page > Table Entries) or more. In the past, we skip that entry and we don't > notify the IOMMU notifiers.

Re: [Qemu-devel] [PATCH v3 01/12] intel-iommu: send PSI always even if across PDEs

2018-05-17 Thread Michael S. Tsirkin
On Thu, May 17, 2018 at 04:59:16PM +0800, Peter Xu wrote: > During IOVA page table walking, there is a special case when the PSI > covers one whole PDE (Page Directory Entry, which contains 512 Page > Table Entries) or more. In the past, we skip that entry and we don't > notify the IOMMU

[Qemu-devel] [PATCH v3 01/12] intel-iommu: send PSI always even if across PDEs

2018-05-17 Thread Peter Xu
During IOVA page table walking, there is a special case when the PSI covers one whole PDE (Page Directory Entry, which contains 512 Page Table Entries) or more. In the past, we skip that entry and we don't notify the IOMMU notifiers. This is not correct. We should send UNMAP notification to