Re: [Qemu-devel] [PATCH v3 02/16] i2c: have I2C receive operation return uint8_t

2018-11-26 Thread Corey Minyard
On 11/26/18 2:23 PM, Philippe Mathieu-Daudé wrote: Hi Corey, On 26/11/18 21:04, miny...@acm.org wrote: From: Corey Minyard It is never supposed to fail and cannot return an error, so just have it return the proper type. Have it return 0xff on nothing available, since that's what would

Re: [Qemu-devel] [PATCH v3 02/16] i2c: have I2C receive operation return uint8_t

2018-11-26 Thread Philippe Mathieu-Daudé
Hi Corey, On 26/11/18 21:04, miny...@acm.org wrote: > From: Corey Minyard > > It is never supposed to fail and cannot return an error, so just > have it return the proper type. Have it return 0xff on nothing > available, since that's what would happen on a real bus. > > Signed-off-by: Corey

[Qemu-devel] [PATCH v3 02/16] i2c: have I2C receive operation return uint8_t

2018-11-26 Thread minyard
From: Corey Minyard It is never supposed to fail and cannot return an error, so just have it return the proper type. Have it return 0xff on nothing available, since that's what would happen on a real bus. Signed-off-by: Corey Minyard Reviewed-by: Peter Maydell --- hw/arm/pxa2xx.c |