Re: [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function.

2015-11-30 Thread Peter Xu
On Mon, Nov 30, 2015 at 01:55:01PM +0100, Paolo Bonzini wrote: > > > On 30/11/2015 12:32, Peter Xu wrote: > > if (*errp) { > > s->status = DUMP_STATUS_FAILED; > > Why not move this "if" to dump_process as well? Yes. I did that in another patch. I will move it to this patch, which

[Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function.

2015-11-30 Thread Peter Xu
No functional change. Cleanup only. Signed-off-by: Peter Xu --- dump.c| 19 ++- include/sysemu/dump.h | 3 +++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/dump.c b/dump.c index 110dbf9..c8ae5c3 100644 --- a/dump.c +++

Re: [Qemu-devel] [PATCH v3 05/12] dump-guest-memory: introduce dump_process() helper function.

2015-11-30 Thread Paolo Bonzini
On 30/11/2015 12:32, Peter Xu wrote: > if (*errp) { > s->status = DUMP_STATUS_FAILED; Why not move this "if" to dump_process as well? Paolo