Re: [Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-18 Thread Igor Mammedov
On Fri, 15 Jun 2018 16:04:43 +0200 David Hildenbrand wrote: > Importantly, get_vmstate_memory_region() should also fail with a proper > error if called before the device is realized. For a PCDIMM, both functions > are to return the same thing, so share the implementation. > > All current users

Re: [Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-17 Thread David Gibson
On Fri, Jun 15, 2018 at 04:04:43PM +0200, David Hildenbrand wrote: > Importantly, get_vmstate_memory_region() should also fail with a proper > error if called before the device is realized. For a PCDIMM, both functions > are to return the same thing, so share the implementation. > > All current

[Qemu-devel] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region()

2018-06-15 Thread David Hildenbrand
Importantly, get_vmstate_memory_region() should also fail with a proper error if called before the device is realized. For a PCDIMM, both functions are to return the same thing, so share the implementation. All current users are called after the device has been realized, so we can expect the