Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-31 Thread Samuel Ortiz
Hi Philippe, On Tue, Oct 30, 2018 at 07:04:15PM +0100, Philippe Mathieu-Daudé wrote: > > > > > +void acpi_get_pci_holes(Range *hole, Range *hole64) > > > > > > ... and this function neither, it should stay in hw/i386/acpi-build.c, > > > thus > > > you don't need to modify the prototype and can

Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-30 Thread Philippe Mathieu-Daudé
Hi Samuel, On 30/10/18 15:57, Samuel Ortiz wrote: Hi Philippe, On Mon, Oct 29, 2018 at 08:29:38PM +0100, Philippe Mathieu-Daudé wrote: On 29/10/18 20:23, Philippe Mathieu-Daudé wrote: On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong The AML build routines for the PCI host bridge

Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-30 Thread Samuel Ortiz
Hi Philippe, On Mon, Oct 29, 2018 at 08:29:38PM +0100, Philippe Mathieu-Daudé wrote: > On 29/10/18 20:23, Philippe Mathieu-Daudé wrote: > > On 29/10/18 18:01, Samuel Ortiz wrote: > > > From: Yang Zhong > > > > > > The AML build routines for the PCI host bridge and the corresponding > > > DSDT

Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 20:23, Philippe Mathieu-Daudé wrote: On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong The AML build routines for the PCI host bridge and the corresponding DSDT addition are neither x86 nor PC machine type specific. We can move them to the architecture agnostic hw/acpi

Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-29 Thread Philippe Mathieu-Daudé
On 29/10/18 18:01, Samuel Ortiz wrote: From: Yang Zhong The AML build routines for the PCI host bridge and the corresponding DSDT addition are neither x86 nor PC machine type specific. We can move them to the architecture agnostic hw/acpi folder, and by carrying all the needed information

[Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

2018-10-29 Thread Samuel Ortiz
From: Yang Zhong The AML build routines for the PCI host bridge and the corresponding DSDT addition are neither x86 nor PC machine type specific. We can move them to the architecture agnostic hw/acpi folder, and by carrying all the needed information through a new AcpiPciBus structure, we can