Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-19 Thread Petar Jovanovic
...@aurel32.net; afaer...@suse.de; Alex Bennée Subject: RE: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss ping http://patchwork.ozlabs.org/patch/287211/ http://patchwork.ozlabs.org/patch/287213/ Riku? Regards, Petar

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-12 Thread Petar Jovanovic
ping http://patchwork.ozlabs.org/patch/287211/ http://patchwork.ozlabs.org/patch/287213/ Riku? Regards, Petar

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-06 Thread Petar Jovanovic
-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss I've looked back and I can see the point of moving it out of the syscall.c into the appropriate linux-user/${foo}/target_structs.h. However for the cases where the given structure is identical maybe

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-05 Thread Alex Bennée
petar.jovano...@imgtec.com writes: From: Alex Bennée [alex.ben...@linaro.org] snip There is an awful lot of similarity between a lot of the structures while not being totally identical. Given the syscall munging is common is there not an argument

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-05 Thread Peter Maydell
On 5 November 2013 14:46, Alex Bennée alex.ben...@linaro.org wrote: Where is the reference for each of these structures? The kernels own headers or glibc's for the appropriate arch? Always the kernel -- we are implementing the syscall interface, not the glibc function. -- PMM

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-04 Thread Alex Bennée
petar.jovano...@rt-rk.com writes: From: Petar Jovanovic petar.jovano...@imgtec.com Creating target_structs header in linux-user/$arch/ and making target_ipc_perm and target_shmid_ds its first inhabitants. The struct defintions may/should be further fine-tuned by arch maintainers.

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-04 Thread Petar Jovanovic
-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss There is an awful lot of similarity between a lot of the structures while not being totally identical. Given the syscall munging is common is there not an argument for having a common header

Re: [Qemu-devel] [PATCH v3 1/2] linux-user: create target_structsheader to place ipc_perm and shmid_dss

2013-11-04 Thread Peter Maydell
On 4 November 2013 18:55, Petar Jovanovic petar.jovano...@imgtec.com wrote: I am not sure I understand your point. This used to be all in one file, now it is divided in arch-specific files that can be later populated with other target specific struct definitions. This was also suggested in the