On 18.06.2018 14:03, Igor Mammedov wrote:
> On Fri, 15 Jun 2018 16:04:46 +0200
> David Hildenbrand wrote:
>
>> It is inititally 0, so setting it to 0 should be allowed, too.
> I'm not sure if we need to permit it.
> By default labels are disabled (label-size=0) and user are supposed to provide
>
On Fri, 15 Jun 2018 16:04:46 +0200
David Hildenbrand wrote:
> It is inititally 0, so setting it to 0 should be allowed, too.
I'm not sure if we need to permit it.
By default labels are disabled (label-size=0) and user are supposed to provide
this option if labels should be enabled with a valid si
On 16.06.2018 04:05, Haozhong Zhang wrote:
> On 06/15/18 16:04, David Hildenbrand wrote:
>> It is inititally 0, so setting it to 0 should be allowed, too.
>
> I'm fine with this change and believe nothing is broken in practice,
> but what is expected by the user who sets a zero label size?
I'd sa
On 06/15/18 16:04, David Hildenbrand wrote:
> It is inititally 0, so setting it to 0 should be allowed, too.
I'm fine with this change and believe nothing is broken in practice,
but what is expected by the user who sets a zero label size?
Look at nvdimm_dsm_device() which enables label DSMs only
It is inititally 0, so setting it to 0 should be allowed, too.
Signed-off-by: David Hildenbrand
---
hw/mem/nvdimm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index db7d8c3050..df7646488b 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvd
