Re: [Qemu-devel] [PATCH v3 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-23 Thread Richard Henderson
On 02/23/2018 07:36 AM, Alex Bennée wrote: > case 0x9: /* FMUL, FMULX */ > -if (!extract32(size, 1, 1)) { > +if (size == 1 || > +(size < 2 && !arm_dc_feature(s, ARM_FEATURE_V8_FP16))) { > unallocated_encoding(s); You get to drop the check here... > +

[Qemu-devel] [PATCH v3 14/31] arm/translate-a64: add FP16 FMULX/MLS/FMLA to simd_indexed

2018-02-23 Thread Alex Bennée
The helpers use the new re-factored muladd support in SoftFloat for the float16 work. Signed-off-by: Alex Bennée --- v3 - re-jigged switch statement to fall-through for unalloc - added is_fp16 bool for fpst - fixed up some long lines --- target/arm/translate-a64.c