Re: [Qemu-devel] [PATCH v3 16/22] memory-device: add optional function get_device_id()

2018-09-25 Thread David Hildenbrand
On 24/09/2018 16:40, Igor Mammedov wrote: > On Thu, 20 Sep 2018 12:32:37 +0200 > David Hildenbrand wrote: > >> When reporting the id of virtio-based memory devices, we always have to >> take the one of the proxy device (parent), not the one of the memory >> device directly. >> >> Let's

Re: [Qemu-devel] [PATCH v3 16/22] memory-device: add optional function get_device_id()

2018-09-24 Thread Igor Mammedov
On Thu, 20 Sep 2018 12:32:37 +0200 David Hildenbrand wrote: > When reporting the id of virtio-based memory devices, we always have to > take the one of the proxy device (parent), not the one of the memory > device directly. > > Let's generalize this by allowing memory devices to specify an

Re: [Qemu-devel] [PATCH v3 16/22] memory-device: add optional function get_device_id()

2018-09-23 Thread David Gibson
On Thu, Sep 20, 2018 at 12:32:37PM +0200, David Hildenbrand wrote: > When reporting the id of virtio-based memory devices, we always have to > take the one of the proxy device (parent), not the one of the memory > device directly. > > Let's generalize this by allowing memory devices to specify an

[Qemu-devel] [PATCH v3 16/22] memory-device: add optional function get_device_id()

2018-09-20 Thread David Hildenbrand
When reporting the id of virtio-based memory devices, we always have to take the one of the proxy device (parent), not the one of the memory device directly. Let's generalize this by allowing memory devices to specify an optional "get_device_id" function. This id can then be used to report errors