Re: [Qemu-devel] [PATCH v4] hw/acpi: extract acpi_add_rom_blob()

2019-03-22 Thread Igor Mammedov
On Fri, 22 Mar 2019 08:20:27 +0800 Wei Yang wrote: > On Thu, Mar 21, 2019 at 02:50:42PM +0100, Igor Mammedov wrote: > >On Thu, 21 Mar 2019 08:21:53 +0800 > >Wei Yang wrote: > > > >> arm and i386 has almost the same function acpi_add_rom_blob(), except > >> giving different FWCfgCallback functi

Re: [Qemu-devel] [PATCH v4] hw/acpi: extract acpi_add_rom_blob()

2019-03-21 Thread Wei Yang
On Thu, Mar 21, 2019 at 02:50:42PM +0100, Igor Mammedov wrote: >On Thu, 21 Mar 2019 08:21:53 +0800 >Wei Yang wrote: > >> arm and i386 has almost the same function acpi_add_rom_blob(), except >> giving different FWCfgCallback function. >> >> This patch moves acpi_add_rom_blob() to utils.c by passi

Re: [Qemu-devel] [PATCH v4] hw/acpi: extract acpi_add_rom_blob()

2019-03-21 Thread Igor Mammedov
On Thu, 21 Mar 2019 08:21:53 +0800 Wei Yang wrote: > arm and i386 has almost the same function acpi_add_rom_blob(), except > giving different FWCfgCallback function. > > This patch moves acpi_add_rom_blob() to utils.c by passing > FWCfgCallback to it. > > Signed-off-by: Wei Yang > > --- > v4:

[Qemu-devel] [PATCH v4] hw/acpi: extract acpi_add_rom_blob()

2019-03-20 Thread Wei Yang
arm and i386 has almost the same function acpi_add_rom_blob(), except giving different FWCfgCallback function. This patch moves acpi_add_rom_blob() to utils.c by passing FWCfgCallback to it. Signed-off-by: Wei Yang --- v4: * extract -> moves * adjust comment in source to make checkpatch hap