Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Fam Zheng
Rich, Please try this version with libguestfs. Thanks. (missing CC due to improper git send-email config) On Wed, 05/22 11:16, Fam Zheng wrote: CURL library API has changed, the current curl driver is not working. This patch rewrites the use of API as well as the structure of internal

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Richard W.M. Jones
On Wed, May 22, 2013 at 11:16:40AM +0800, Fam Zheng wrote: Changes from v3: 01, 06, 07: Add QLIST_INIT in qemu_open to initialize each list. 07: Move clean up for s-acbs from later patch to here. Use qemu_aio_relase instead of g_free on acb. Fix use-after-free bug. [Rich] This

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Paolo Bonzini
Il 22/05/2013 11:44, Richard W.M. Jones ha scritto: On Wed, May 22, 2013 at 11:16:40AM +0800, Fam Zheng wrote: Changes from v3: 01, 06, 07: Add QLIST_INIT in qemu_open to initialize each list. 07: Move clean up for s-acbs from later patch to here. Use qemu_aio_relase instead of g_free on

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Richard W.M. Jones
On Wed, May 22, 2013 at 01:04:51PM +0200, Paolo Bonzini wrote: Something is trying to write, but there's no write operation defined for CURL. I guess curl (and other backends too) should reject being opened for write. Alternatively, block.c could do that for them. Yes, I'd just got to that

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Stefan Hajnoczi
On Wed, May 22, 2013 at 12:12:24PM +0100, Richard W.M. Jones wrote: On Wed, May 22, 2013 at 01:04:51PM +0200, Paolo Bonzini wrote: Something is trying to write, but there's no write operation defined for CURL. I guess curl (and other backends too) should reject being opened for write.

Re: [Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-22 Thread Fam Zheng
On Wed, 05/22 16:39, Stefan Hajnoczi wrote: On Wed, May 22, 2013 at 12:12:24PM +0100, Richard W.M. Jones wrote: On Wed, May 22, 2013 at 01:04:51PM +0200, Paolo Bonzini wrote: Something is trying to write, but there's no write operation defined for CURL. I guess curl (and other

[Qemu-devel] [PATCH v4 00/10] curl: fix curl read

2013-05-21 Thread Fam Zheng
CURL library API has changed, the current curl driver is not working. This patch rewrites the use of API as well as the structure of internal states. BDRVCURLState holds the pointer to curl multi interface (man 3 libcurl-multi), and 4 lists for internal states: - CURLState holds state for