Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread John Snow
On 09/05/2018 06:27 AM, Max Reitz wrote: > On 2018-09-04 22:32, John Snow wrote: >> >> >> On 09/04/2018 02:46 PM, Jeff Cody wrote: >>> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: Use the component callbacks; prepare, abort, and clean. NB: prepare is only called

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
On 2018-09-05 13:53, Kevin Wolf wrote: > Am 05.09.2018 um 13:37 hat Max Reitz geschrieben: >> On 2018-09-05 12:49, Kevin Wolf wrote: >>> Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: On 2018-09-04 22:32, John Snow wrote: > > > On 09/04/2018 02:46 PM, Jeff Cody wrote: >> On

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Kevin Wolf
Am 05.09.2018 um 13:37 hat Max Reitz geschrieben: > On 2018-09-05 12:49, Kevin Wolf wrote: > > Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: > >> On 2018-09-04 22:32, John Snow wrote: > >>> > >>> > >>> On 09/04/2018 02:46 PM, Jeff Cody wrote: > On Tue, Sep 04, 2018 at 01:09:19PM -0400,

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
On 2018-09-05 12:49, Kevin Wolf wrote: > Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: >> On 2018-09-04 22:32, John Snow wrote: >>> >>> >>> On 09/04/2018 02:46 PM, Jeff Cody wrote: On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: > Use the component callbacks; prepare,

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Kevin Wolf
Am 05.09.2018 um 12:27 hat Max Reitz geschrieben: > On 2018-09-04 22:32, John Snow wrote: > > > > > > On 09/04/2018 02:46 PM, Jeff Cody wrote: > >> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: > >>> Use the component callbacks; prepare, abort, and clean. > >>> > >>> NB: prepare is

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-05 Thread Max Reitz
On 2018-09-04 22:32, John Snow wrote: > > > On 09/04/2018 02:46 PM, Jeff Cody wrote: >> On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: >>> Use the component callbacks; prepare, abort, and clean. >>> >>> NB: prepare is only called when the job has not yet failed; >>> and abort can be

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-04 Thread John Snow
On 09/04/2018 02:46 PM, Jeff Cody wrote: > On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: >> Use the component callbacks; prepare, abort, and clean. >> >> NB: prepare is only called when the job has not yet failed; >> and abort can be called after prepare. >> >> complete -> prepare

Re: [Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-04 Thread Jeff Cody
On Tue, Sep 04, 2018 at 01:09:19PM -0400, John Snow wrote: > Use the component callbacks; prepare, abort, and clean. > > NB: prepare is only called when the job has not yet failed; > and abort can be called after prepare. > > complete -> prepare -> abort -> clean > complete -> abort -> clean >

[Qemu-devel] [PATCH v4 04/15] block/commit: refactor commit to use job callbacks

2018-09-04 Thread John Snow
Use the component callbacks; prepare, abort, and clean. NB: prepare is only called when the job has not yet failed; and abort can be called after prepare. complete -> prepare -> abort -> clean complete -> abort -> clean Signed-off-by: John Snow Reviewed-by: Max Reitz --- block/commit.c | 90