Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-12 Thread Stefan Hajnoczi
On Wed, Jan 11, 2012 at 03:18:28PM -0200, Luiz Capitulino wrote: On Fri, 6 Jan 2012 14:01:30 + Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: +int stream_start(BlockDriverState *bs, BlockDriverState *base, + BlockDriverCompletionFunc *cb, void *opaque) +{ +

Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-12 Thread Kevin Wolf
Am 06.01.2012 15:01, schrieb Stefan Hajnoczi: Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile.objs |1 + block/stream.c | 119 block_int.h|3 + trace-events |4 ++ 4 files changed, 127

Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-12 Thread Stefan Hajnoczi
On Thu, Jan 12, 2012 at 10:59 AM, Kevin Wolf kw...@redhat.com wrote: Am 06.01.2012 15:01, schrieb Stefan Hajnoczi: +    buf = qemu_blockalign(bs, STREAM_BUFFER_SIZE); +    s-common.len = bdrv_getlength(bs); No error check? Will fix. +    bdrv_get_geometry(bs, (uint64_t *)end); Why call

Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-12 Thread Kevin Wolf
Am 12.01.2012 12:39, schrieb Stefan Hajnoczi: On Thu, Jan 12, 2012 at 10:59 AM, Kevin Wolf kw...@redhat.com wrote: Am 06.01.2012 15:01, schrieb Stefan Hajnoczi: +buf = qemu_blockalign(bs, STREAM_BUFFER_SIZE); +s-common.len = bdrv_getlength(bs); No error check? Will fix. +

Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-12 Thread Stefan Hajnoczi
On Thu, Jan 12, 2012 at 12:53 PM, Kevin Wolf kw...@redhat.com wrote: Am 12.01.2012 12:39, schrieb Stefan Hajnoczi: On Thu, Jan 12, 2012 at 10:59 AM, Kevin Wolf kw...@redhat.com wrote: Am 06.01.2012 15:01, schrieb Stefan Hajnoczi: +    buf = qemu_blockalign(bs, STREAM_BUFFER_SIZE); +    

Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-12 Thread Kevin Wolf
Am 12.01.2012 14:05, schrieb Stefan Hajnoczi: On Thu, Jan 12, 2012 at 12:53 PM, Kevin Wolf kw...@redhat.com wrote: Am 12.01.2012 12:39, schrieb Stefan Hajnoczi: On Thu, Jan 12, 2012 at 10:59 AM, Kevin Wolf kw...@redhat.com wrote: Am 06.01.2012 15:01, schrieb Stefan Hajnoczi: +buf =

Re: [Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-11 Thread Luiz Capitulino
On Fri, 6 Jan 2012 14:01:30 + Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile.objs |1 + block/stream.c | 119 block_int.h|3 +

[Qemu-devel] [PATCH v4 04/15] block: add image streaming block job

2012-01-06 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile.objs |1 + block/stream.c | 119 block_int.h|3 + trace-events |4 ++ 4 files changed, 127 insertions(+), 0 deletions(-) create mode 100644