Re: [Qemu-devel] [PATCH v4 06/22] qobject: Perform %% interpolation in qobject_from_jsonf()

2017-08-09 Thread Eric Blake
On 08/09/2017 04:06 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We want -Wformat to catch blatant programming errors in format >> strings that we pass to qobject_from_jsonf(). But if someone >> were to pass a JSON string "'%s'" as the format string, gcc would >> insist that it be pair

Re: [Qemu-devel] [PATCH v4 06/22] qobject: Perform %% interpolation in qobject_from_jsonf()

2017-08-09 Thread Markus Armbruster
Eric Blake writes: > We want -Wformat to catch blatant programming errors in format > strings that we pass to qobject_from_jsonf(). But if someone > were to pass a JSON string "'%s'" as the format string, gcc would > insist that it be paired with a char* argument, even though our > lexer does no

[Qemu-devel] [PATCH v4 06/22] qobject: Perform %% interpolation in qobject_from_jsonf()

2017-08-03 Thread Eric Blake
We want -Wformat to catch blatant programming errors in format strings that we pass to qobject_from_jsonf(). But if someone were to pass a JSON string "'%s'" as the format string, gcc would insist that it be paired with a char* argument, even though our lexer does not recognize % sequences inside