Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-12-02 Thread Eric Blake
On 12/01/2015 06:11 PM, Fam Zheng wrote: > On Tue, 12/01 21:28, Peter Xu wrote: >> One new QMP event DUMP_COMPLETED is added. When a dump finishes, one >> DUMP_COMPLETED event will occur to notify the user. >> >> Signed-off-by: Peter Xu >> --- >> +++ b/qapi/event.json >> @@

Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-12-02 Thread Eric Blake
On 12/02/2015 08:21 AM, Peter Xu wrote: > On Wed, Dec 02, 2015 at 07:45:52AM -0700, Eric Blake wrote: >> On 12/01/2015 06:11 PM, Fam Zheng wrote: >>> Please explicitly mention that successful dump emits DUMP_COMPLETED without >>> error, and failed dump emits DUMP_COMPLETED that has an error str.

Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-12-02 Thread Peter Xu
On Wed, Dec 02, 2015 at 07:45:52AM -0700, Eric Blake wrote: > On 12/01/2015 06:11 PM, Fam Zheng wrote: > > Please explicitly mention that successful dump emits DUMP_COMPLETED without > > error, and failed dump emits DUMP_COMPLETED that has an error str. > > In fact, I wonder if it would also be

Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-12-02 Thread Peter Xu
On Wed, Dec 02, 2015 at 09:11:31AM +0800, Fam Zheng wrote: > On Tue, 12/01 21:28, Peter Xu wrote: > > + > > +## > > +# @DUMP_COMPLETED > > +# > > +# Emitted when background dump has completed > > +# > > +# @error: #optional human-readable error string that provides > > +# hint on why dump

Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-12-02 Thread Fam Zheng
On Wed, 12/02 16:20, Peter Xu wrote: > On Wed, Dec 02, 2015 at 09:11:31AM +0800, Fam Zheng wrote: > > On Tue, 12/01 21:28, Peter Xu wrote: > > > + > > > +## > > > +# @DUMP_COMPLETED > > > +# > > > +# Emitted when background dump has completed > > > +# > > > +# @error: #optional human-readable

Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-12-02 Thread Peter Xu
On Wed, Dec 02, 2015 at 09:01:16AM -0700, Eric Blake wrote: > On 12/02/2015 08:21 AM, Peter Xu wrote: > > Will the raw memory total size useful in any way? I am totally ok to > > add this, just failed to find a way for user to use it besides > > calculating finished work during dump... :( > >

Re: [Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-12-01 Thread Fam Zheng
On Tue, 12/01 21:28, Peter Xu wrote: > One new QMP event DUMP_COMPLETED is added. When a dump finishes, one > DUMP_COMPLETED event will occur to notify the user. > > Signed-off-by: Peter Xu > --- > docs/qmp-events.txt | 16 > dump.c | 11

[Qemu-devel] [PATCH v4 08/11] dump-guest-memory: add qmp event DUMP_COMPLETED

2015-12-01 Thread Peter Xu
One new QMP event DUMP_COMPLETED is added. When a dump finishes, one DUMP_COMPLETED event will occur to notify the user. Signed-off-by: Peter Xu --- docs/qmp-events.txt | 16 dump.c | 11 +-- qapi-schema.json| 3 ++- qapi/event.json