On Thu, Jul 27, 2017 at 9:39 AM, Amador Pahim wrote:
> On Wed, Jul 26, 2017 at 7:35 PM, Stefan Hajnoczi wrote:
>> On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote:
>>> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote:
>>> > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote:
>>>
On Wed, Jul 26, 2017 at 7:35 PM, Stefan Hajnoczi wrote:
> On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote:
>> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote:
>> > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote:
>> >> Signed-off-by: Amador Pahim
>> >> Reviewed-by: Fam Zhen
On 07/26/2017 01:35 PM, Stefan Hajnoczi wrote:
> On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote:
>> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote:
>>> On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote:
Signed-off-by: Amador Pahim
Reviewed-by: Fam Zheng
---
On Tue, Jul 25, 2017 at 11:30:16AM -0400, Cleber Rosa wrote:
> On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote:
> > On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote:
> >> Signed-off-by: Amador Pahim
> >> Reviewed-by: Fam Zheng
> >> ---
> >> scripts/qemu.py | 10 +-
On 07/25/2017 09:37 AM, Stefan Hajnoczi wrote:
> On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote:
>> Let's make args public so users can extend it without feeling like
>> abusing the internal API.
>
> Nothing is abusing an internal API. PEP8 describes the difference
> between publi
On Tue, Jul 25, 2017 at 3:37 PM, Stefan Hajnoczi wrote:
> On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote:
>> Let's make args public so users can extend it without feeling like
>> abusing the internal API.
>
> Nothing is abusing an internal API. PEP8 describes the difference
> betwee
On Mon, Jul 24, 2017 at 02:44:37PM +0200, Amador Pahim wrote:
> Let's make args public so users can extend it without feeling like
> abusing the internal API.
Nothing is abusing an internal API. PEP8 describes the difference
between public (no underscore), protected aka subclass API (single
under
Let's make args public so users can extend it without feeling like
abusing the internal API.
Signed-off-by: Amador Pahim
Reviewed-by: Fam Zheng
---
scripts/qemu.py | 10 +-
tests/qemu-iotests/iotests.py | 18 +-
2 files changed, 14 insertions(+), 14 deletio