Re: [Qemu-devel] [PATCH v4 10/21] hw: Do not include "exec/ioport.h" if it is not necessary

2018-05-29 Thread Marcel Apfelbaum




On 05/29/2018 02:27 AM, Philippe Mathieu-Daudé wrote:

Code change produced with:
 $ git grep '#include "exec/ioport.h"' hw | \
   cut -d: -f-1 | \
   xargs egrep -Li "(portio|cpu_(in|out).\()" | \
   xargs sed -i.bak '/#include "exec\/ioport.h"/d'

Signed-off-by: Philippe Mathieu-Daudé 
---
  hw/acpi/pcihp.c | 1 -
  hw/acpi/piix4.c | 1 -
  2 files changed, 2 deletions(-)

diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index 91c82fdc7a..80d42e12ff 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -32,7 +32,6 @@
  #include "hw/pci/pci.h"
  #include "hw/acpi/acpi.h"
  #include "sysemu/sysemu.h"
-#include "exec/ioport.h"
  #include "exec/address-spaces.h"
  #include "hw/pci/pci_bus.h"
  #include "qapi/error.h"
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 8b703455b7..6404af5f33 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -28,7 +28,6 @@
  #include "sysemu/sysemu.h"
  #include "qapi/error.h"
  #include "qemu/range.h"
-#include "exec/ioport.h"
  #include "hw/nvram/fw_cfg.h"
  #include "exec/address-spaces.h"
  #include "hw/acpi/piix4.h"


Reviewed-by: Marcel Apfelbaum

Thanks,
Marcel




[Qemu-devel] [PATCH v4 10/21] hw: Do not include "exec/ioport.h" if it is not necessary

2018-05-28 Thread Philippe Mathieu-Daudé
Code change produced with:
$ git grep '#include "exec/ioport.h"' hw | \
  cut -d: -f-1 | \
  xargs egrep -Li "(portio|cpu_(in|out).\()" | \
  xargs sed -i.bak '/#include "exec\/ioport.h"/d'

Signed-off-by: Philippe Mathieu-Daudé 
---
 hw/acpi/pcihp.c | 1 -
 hw/acpi/piix4.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index 91c82fdc7a..80d42e12ff 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -32,7 +32,6 @@
 #include "hw/pci/pci.h"
 #include "hw/acpi/acpi.h"
 #include "sysemu/sysemu.h"
-#include "exec/ioport.h"
 #include "exec/address-spaces.h"
 #include "hw/pci/pci_bus.h"
 #include "qapi/error.h"
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 8b703455b7..6404af5f33 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -28,7 +28,6 @@
 #include "sysemu/sysemu.h"
 #include "qapi/error.h"
 #include "qemu/range.h"
-#include "exec/ioport.h"
 #include "hw/nvram/fw_cfg.h"
 #include "exec/address-spaces.h"
 #include "hw/acpi/piix4.h"
-- 
2.17.0