Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-06 Thread Richard Henderson
On 05/05/2016 11:41 AM, Emilio G. Cota wrote: This is tempting me to just kill the feature, since resizing works very well. And it would save ~90 lines of code. Is anyone against this? Not I. I think it'll nicely simplify things. r~

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-05 Thread Emilio G. Cota
On Wed, May 04, 2016 at 07:22:16 -1000, Richard Henderson wrote: > On 05/04/2016 05:36 AM, Emilio G. Cota wrote: > >BTW in the last couple of days I did some more work beyond v4: > > > >- Added a benchmark (not a correctness test) to measure parallel > > performance of QHT (recall that

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-04 Thread Richard Henderson
On 05/04/2016 05:36 AM, Emilio G. Cota wrote: BTW in the last couple of days I did some more work beyond v4: - Added a benchmark (not a correctness test) to measure parallel performance of QHT (recall that test/qht-test is sequential.) - Added support for concurrent insertions as long as

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-04 Thread Emilio G. Cota
On Tue, May 03, 2016 at 19:24:31 -1000, Richard Henderson wrote: > On 05/03/2016 07:26 AM, Emilio G. Cota wrote: > >Ouch, sorry. Won't happen again. > > > >Grab the missing pre-requisite patch from: > > http://patchwork.ozlabs.org/patch/607662/mbox/ > > Well, that said, there are further

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-04 Thread Alex Bennée
Richard Henderson writes: > On 05/03/2016 07:26 AM, Emilio G. Cota wrote: >> On Tue, May 03, 2016 at 08:36:35 +0100, Alex Bennée wrote: >>> Emilio G. Cota writes: static TranslationBlock *tb_find_physical(CPUState *cpu,

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-03 Thread Richard Henderson
On 05/03/2016 07:26 AM, Emilio G. Cota wrote: On Tue, May 03, 2016 at 08:36:35 +0100, Alex Bennée wrote: Emilio G. Cota writes: static TranslationBlock *tb_find_physical(CPUState *cpu, target_ulong pc,

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-03 Thread Richard Henderson
On 04/29/2016 05:33 PM, Emilio G. Cota wrote: Reviewed-by: Alex Bennée Signed-off-by: Emilio G. Cota --- cpu-exec.c | 82 --- include/exec/exec-all.h | 9 +++--- include/exec/tb-hash.h | 3 +-

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-03 Thread Emilio G. Cota
On Tue, May 03, 2016 at 08:36:35 +0100, Alex Bennée wrote: > Emilio G. Cota writes: > > static TranslationBlock *tb_find_physical(CPUState *cpu, > >target_ulong pc, > >target_ulong cs_base, >

Re: [Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-05-03 Thread Alex Bennée
Emilio G. Cota writes: > Having a fixed-size hash table for keeping track of all translation blocks > is suboptimal: some workloads are just too big or too small to get maximum > performance from the hash table. The MRU promotion policy helps improve > performance when the hash

[Qemu-devel] [PATCH v4 13/14] tb hash: track translated blocks with qht

2016-04-29 Thread Emilio G. Cota
Having a fixed-size hash table for keeping track of all translation blocks is suboptimal: some workloads are just too big or too small to get maximum performance from the hash table. The MRU promotion policy helps improve performance when the hash table is a little undersized, but it cannot make