Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

2017-07-12 Thread Eric Blake
On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: > This function is not used anywhere, so remove it. > > Signed-off-by: Manos Pitsidianakis > --- > block.c | 14 -- > block/raw-format.c| 6 -- > include/block/block.h | 1 -

Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

2017-07-12 Thread Manos Pitsidianakis
On Wed, Jul 12, 2017 at 05:15:01PM +0200, Kevin Wolf wrote: Am 12.07.2017 um 09:41 hat Markus Armbruster geschrieben: Eric Blake writes: > On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: >> This function is not used anywhere, so remove it. >> > > Might be interesting to

Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

2017-07-12 Thread Kevin Wolf
Am 12.07.2017 um 09:41 hat Markus Armbruster geschrieben: > Eric Blake writes: > > > On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: > >> This function is not used anywhere, so remove it. > >> > > > > Might be interesting to figure out when it WAS last used. > > Yes.

Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

2017-07-12 Thread Stefan Hajnoczi
On Tue, Jul 11, 2017 at 07:37:46PM +0300, Manos Pitsidianakis wrote: > This function is not used anywhere, so remove it. > > Signed-off-by: Manos Pitsidianakis > --- > block.c | 14 -- > block/raw-format.c| 6 -- >

Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

2017-07-12 Thread Markus Armbruster
Eric Blake writes: > On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: >> This function is not used anywhere, so remove it. >> > > Might be interesting to figure out when it WAS last used. Yes. When I see "remove X because it's unused" during patch review, I immediately

Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

2017-07-11 Thread Eric Blake
On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote: > This function is not used anywhere, so remove it. > Might be interesting to figure out when it WAS last used. If I grepped correctly, it was commit 21fcf360 back in May 2012? > Signed-off-by: Manos Pitsidianakis > ---

[Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed

2017-07-11 Thread Manos Pitsidianakis
This function is not used anywhere, so remove it. Signed-off-by: Manos Pitsidianakis --- block.c | 14 -- block/raw-format.c| 6 -- include/block/block.h | 1 - include/block/block_int.h | 1 - 4 files changed, 22