Re: [Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c

2018-07-06 Thread Aleksandar Markovic
> I'm not sure it's worth having this but you are the maintainer so your > choice :) If someone in future peruses an older version of this file (let's say, while working on an older version of QEMU), and comes across this problem with checkpatch.pl, by checking the full history of the file,

Re: [Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c

2018-07-06 Thread Philippe Mathieu-Daudé
Hi Aleksandar, On 07/06/2018 12:38 PM, Aleksandar Markovic wrote: > Hi, Paolo, > > It was an incredibly fast fix! :) > > I already confirmed that the fix fixes the problem on msa_helper.c. I would > nevertheless like to have this workaround applied. Can you perhaps give it > "Reviewed-by"? >

Re: [Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c

2018-07-06 Thread Aleksandar Markovic
Hi, Paolo, It was an incredibly fast fix! :) I already confirmed that the fix fixes the problem on msa_helper.c. I would nevertheless like to have this workaround applied. Can you perhaps give it "Reviewed-by"? Regards, Aleksandar > Subject: [PATCH v4 2/8] target/mips: Workaround for

[Qemu-devel] [PATCH v4 2/8] target/mips: Workaround for checkpatch.pl hanging on msa_helper.c

2018-07-06 Thread Aleksandar Markovic
From: Aleksandar Markovic If checkpatch.pl is applied (using switch "-f") on file target/mips/msa_helper.c, it will hang. This is a workaround by correcting the source file. The workaround is found by partial deleting and undeleting of the code in msa_helper.c in binary search fashion. The bug