Re: [Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-15 Thread Gerd Hoffmann
> > Well, it's simliar to qxl vs. qxl-vga. It's not qxl,vga={on,off} and > > libvirt has no problems to deal with that ... > > > > Another more technical reason is (again) hotplug. ramfb needs an fw_cfg > > entry for configuration, and fw_cfg entries can't be hotplugged. So > > hotplugging

Re: [Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-14 Thread Erik Skultety
On Thu, Jun 14, 2018 at 12:36:25AM +0200, Gerd Hoffmann wrote: > On Wed, Jun 13, 2018 at 01:50:47PM -0600, Alex Williamson wrote: > > On Wed, 13 Jun 2018 10:41:49 +0200 > > Gerd Hoffmann wrote: > > > > > So we have a boot display when using a vgpu as primary display. > > > > > > Use

Re: [Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-14 Thread Laszlo Ersek
On 06/14/18 00:36, Gerd Hoffmann wrote: > On Wed, Jun 13, 2018 at 01:50:47PM -0600, Alex Williamson wrote: >> I suppose in the UEFI case runtime services can be used to continue >> writing this display, > > Yes. Small clarification for the wording -- "UEFI runtime services" do not include

Re: [Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-13 Thread Gerd Hoffmann
On Wed, Jun 13, 2018 at 01:50:47PM -0600, Alex Williamson wrote: > On Wed, 13 Jun 2018 10:41:49 +0200 > Gerd Hoffmann wrote: > > > So we have a boot display when using a vgpu as primary display. > > > > Use vfio-pci-ramfb instead of vfio-pci to enable it. > > Using a different device here

Re: [Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-13 Thread Alex Williamson
On Wed, 13 Jun 2018 10:41:49 +0200 Gerd Hoffmann wrote: > So we have a boot display when using a vgpu as primary display. > > Use vfio-pci-ramfb instead of vfio-pci to enable it. Using a different device here seems like it almost guarantees a very complicated path to support under libvirt.

[Qemu-devel] [PATCH v4 3/3] hw/vfio/display: add ramfb support

2018-06-13 Thread Gerd Hoffmann
So we have a boot display when using a vgpu as primary display. Use vfio-pci-ramfb instead of vfio-pci to enable it. Signed-off-by: Gerd Hoffmann --- include/hw/vfio/vfio-common.h | 2 ++ hw/vfio/display.c | 10 ++ hw/vfio/pci.c | 15 +++ 3