Re: [Qemu-devel] [PATCH v4 3/4] linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes

2019-04-29 Thread Richard Henderson
On 4/29/19 9:17 AM, Peter Maydell wrote: >> +struct elf_phdr *eppnt = phdr + i; >> + >> +switch (eppnt->p_type) { >> +case PT_LOAD: >> +{ > > I think you have an extra layer of indent here that we usually > don't do for switch statement cases. No, that indent

Re: [Qemu-devel] [PATCH v4 3/4] linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes

2019-04-29 Thread Peter Maydell
On Sat, 30 Mar 2019 at 00:59, Richard Henderson wrote: > > For aarch64, this includes the GNU_PROPERTY_AARCH64_FEATURE_1_BTI bit, > which indicates that the image should be mapped with guarded pages. > > Signed-off-by: Richard Henderson > --- > linux-user/elfload.c | 79

[Qemu-devel] [PATCH v4 3/4] linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes

2019-03-29 Thread Richard Henderson
For aarch64, this includes the GNU_PROPERTY_AARCH64_FEATURE_1_BTI bit, which indicates that the image should be mapped with guarded pages. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 79 ++-- 1 file changed, 68 insertions(+), 11