Re: [Qemu-devel] [PATCH v5 06/16] block/mirror: conservative mirror_exit refactor

2018-09-07 Thread Max Reitz
On 2018-09-06 22:31, John Snow wrote: > > > On 09/06/2018 12:57 PM, Jeff Cody wrote: >> On Thu, Sep 06, 2018 at 09:02:15AM -0400, John Snow wrote: >>> For purposes of minimum code movement, refactor the mirror_exit >>> callback to use the post-finalization callbacks in a trivial way. >>> >>>

Re: [Qemu-devel] [PATCH v5 06/16] block/mirror: conservative mirror_exit refactor

2018-09-06 Thread John Snow
On 09/06/2018 12:57 PM, Jeff Cody wrote: > On Thu, Sep 06, 2018 at 09:02:15AM -0400, John Snow wrote: >> For purposes of minimum code movement, refactor the mirror_exit >> callback to use the post-finalization callbacks in a trivial way. >> >> Signed-off-by: John Snow >> --- >> block/mirror.c

Re: [Qemu-devel] [PATCH v5 06/16] block/mirror: conservative mirror_exit refactor

2018-09-06 Thread Jeff Cody
On Thu, Sep 06, 2018 at 09:02:15AM -0400, John Snow wrote: > For purposes of minimum code movement, refactor the mirror_exit > callback to use the post-finalization callbacks in a trivial way. > > Signed-off-by: John Snow > --- > block/mirror.c | 39 --- > 1

[Qemu-devel] [PATCH v5 06/16] block/mirror: conservative mirror_exit refactor

2018-09-06 Thread John Snow
For purposes of minimum code movement, refactor the mirror_exit callback to use the post-finalization callbacks in a trivial way. Signed-off-by: John Snow --- block/mirror.c | 39 --- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git