Re: [Qemu-devel] [PATCH v5 09/73] ppc: convert to helper_cpu_halted_set

2018-12-15 Thread David Gibson
On Thu, Dec 13, 2018 at 12:03:49AM -0500, Emilio G. Cota wrote:
> Cc: David Gibson 
> Cc: Alexander Graf 
> Cc: qemu-...@nongnu.org
> Reviewed-by: Richard Henderson 
> Reviewed-by: Alex Bennée 
> Signed-off-by: Emilio G. Cota 

Acked-by: David Gibson 

> ---
>  target/ppc/translate.c | 6 ++
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 2b37910248..4bb78f403e 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -1609,8 +1609,7 @@ GEN_LOGICAL2(nor, tcg_gen_nor_tl, 0x03, PPC_INTEGER);
>  static void gen_pause(DisasContext *ctx)
>  {
>  TCGv_i32 t0 = tcg_const_i32(0);
> -tcg_gen_st_i32(t0, cpu_env,
> -   -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted));
> +gen_helper_cpu_halted_set(cpu_env, t0);
>  tcg_temp_free_i32(t0);
>  
>  /* Stop translation, this gives other CPUs a chance to run */
> @@ -3584,8 +3583,7 @@ static void gen_sync(DisasContext *ctx)
>  static void gen_wait(DisasContext *ctx)
>  {
>  TCGv_i32 t0 = tcg_const_i32(1);
> -tcg_gen_st_i32(t0, cpu_env,
> -   -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted));
> +gen_helper_cpu_halted_set(cpu_env, t0);
>  tcg_temp_free_i32(t0);
>  /* Stop translation, as the CPU is supposed to sleep from now */
>  gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next);

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature


[Qemu-devel] [PATCH v5 09/73] ppc: convert to helper_cpu_halted_set

2018-12-12 Thread Emilio G. Cota
Cc: David Gibson 
Cc: Alexander Graf 
Cc: qemu-...@nongnu.org
Reviewed-by: Richard Henderson 
Reviewed-by: Alex Bennée 
Signed-off-by: Emilio G. Cota 
---
 target/ppc/translate.c | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 2b37910248..4bb78f403e 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -1609,8 +1609,7 @@ GEN_LOGICAL2(nor, tcg_gen_nor_tl, 0x03, PPC_INTEGER);
 static void gen_pause(DisasContext *ctx)
 {
 TCGv_i32 t0 = tcg_const_i32(0);
-tcg_gen_st_i32(t0, cpu_env,
-   -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted));
+gen_helper_cpu_halted_set(cpu_env, t0);
 tcg_temp_free_i32(t0);
 
 /* Stop translation, this gives other CPUs a chance to run */
@@ -3584,8 +3583,7 @@ static void gen_sync(DisasContext *ctx)
 static void gen_wait(DisasContext *ctx)
 {
 TCGv_i32 t0 = tcg_const_i32(1);
-tcg_gen_st_i32(t0, cpu_env,
-   -offsetof(PowerPCCPU, env) + offsetof(CPUState, halted));
+gen_helper_cpu_halted_set(cpu_env, t0);
 tcg_temp_free_i32(t0);
 /* Stop translation, as the CPU is supposed to sleep from now */
 gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next);
-- 
2.17.1