Re: [Qemu-devel] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-09-05 Thread Igor Mammedov
On Tue, 4 Sep 2018 22:40:49 -0300 Eduardo Habkost wrote: > On Tue, Sep 04, 2018 at 05:18:48PM +0200, Andrew Jones wrote: > > On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote: > > > commit > > > (5cdc9b76e3 vl.c: Remove dead assignment) > > > removed sockets calculation when

Re: [Qemu-devel] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-09-04 Thread Eduardo Habkost
On Tue, Sep 04, 2018 at 05:18:48PM +0200, Andrew Jones wrote: > On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote: > > commit > > (5cdc9b76e3 vl.c: Remove dead assignment) > > removed sockets calculation when 'sockets' weren't provided on CLI > > since there wasn't any users for it

Re: [Qemu-devel] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-09-04 Thread Andrew Jones
On Tue, Sep 04, 2018 at 03:22:36PM +0200, Igor Mammedov wrote: > commit > (5cdc9b76e3 vl.c: Remove dead assignment) > removed sockets calculation when 'sockets' weren't provided on CLI > since there wasn't any users for it back then. Exiting checks > are neither reachable >} else if (sockets

[Qemu-devel] [PATCH v5 2/2] vl:c: make sure that sockets are calculated correctly in '-smp X' case

2018-09-04 Thread Igor Mammedov
commit (5cdc9b76e3 vl.c: Remove dead assignment) removed sockets calculation when 'sockets' weren't provided on CLI since there wasn't any users for it back then. Exiting checks are neither reachable } else if (sockets * cores * threads < cpus) { or nor triggable if (sockets * cores *