Re: [Qemu-devel] [PATCH v5 3/5] block: Add driver methods to probe blocksizes and geometry

2015-01-02 Thread Stefan Hajnoczi
On Thu, Dec 18, 2014 at 12:18:02PM +0100, Ekaterina Tumanova wrote: > @@ -90,6 +91,10 @@ > #include > #endif > > +#ifdef __s390__ > +#include > +#endif #if defined(__linux__) && defined(__s390__) Or you could move it inside #ifdef __linux__ earlier in the file. > +/** > + * Try to get @bs'

Re: [Qemu-devel] [PATCH v5 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-18 Thread Thomas Huth
On Thu, 18 Dec 2014 12:18:02 +0100 Ekaterina Tumanova wrote: > Introduce driver methods of defining disk blocksizes (physical and > logical) and hard drive geometry. > Methods are only implemented for "host_device". For "raw" devices > driver calls child's method. > > For now geometry detection

[Qemu-devel] [PATCH v5 3/5] block: Add driver methods to probe blocksizes and geometry

2014-12-18 Thread Ekaterina Tumanova
Introduce driver methods of defining disk blocksizes (physical and logical) and hard drive geometry. Methods are only implemented for "host_device". For "raw" devices driver calls child's method. For now geometry detection will only work for DASD devices. To check that a local check_for_dasd funct