Dietmar Maurer diet...@proxmox.com writes:
+# @devlist: #optional list of block device names (separated by ',', ';'
+# or ':'). By default the backup includes all writable block devices.
Make this a proper list, please.
That is, make it a JSON array: '*devlist' : [ 'str' ] Any time
You can easily extend the API to allow multiple backups (In a fully
backwards compatible way). So there is no need to change that now.
I disagree.
You propose something like:
1. - { execute: backup,
arguments: { backup-file: foo.vma } }
- { return: {
Dietmar Maurer diet...@proxmox.com writes:
You can easily extend the API to allow multiple backups (In a fully
backwards compatible way). So there is no need to change that now.
I disagree.
You propose something like:
1. - { execute: backup,
arguments: { backup-file:
With multiple backup support, we still need to keep it working
unchanged when no or just one backup is executing. When more are
executing, we have to make it fail, unless an optional argument is
given.
Again, unnecessary complexity.
Moreover, omitting the optional
First pass, concentrating on interfaces, implementation mostly ignored.
Dietmar Maurer diet...@proxmox.com writes:
We use a generic BackupDriver struct to encapsulate all archive format
related function.
Another option would be to simply dump devid,cluster_num,cluster_data to
the output fh
On 02/27/2013 03:31 AM, Markus Armbruster wrote:
First pass, concentrating on interfaces, implementation mostly ignored.
Dietmar Maurer diet...@proxmox.com writes:
We use a generic BackupDriver struct to encapsulate all archive format
related function.
+# @backup:
+#
+# Starts a VM
+# @devlist: #optional list of block device names (separated by ',', ';'
+# or ':'). By default the backup includes all writable block devices.
Make this a proper list, please.
That is, make it a JSON array: '*devlist' : [ 'str' ] Any time that you pass
a string
through JSON that
We use a generic BackupDriver struct to encapsulate all archive format
related function.
Another option would be to simply dump devid,cluster_num,cluster_data to
the output fh (pipe), and an external binary saves the data. That way we
could move the whole archive format related code out of qemu.
