Re: [Qemu-devel] [PATCH v5 3/6] target: [tcg] Add generic translation framework

2017-01-16 Thread Lluís Vilanova
Richard Henderson writes: > On 12/28/2016 08:28 AM, Lluís Vilanova wrote: >> +typedef enum DisasJumpType { >> +DJ_NEXT, >> +DJ_TOO_MANY, >> +DJ_TARGET, >> +} DisasJumpType; > I wonder if enums like DJ_TARGET_{0..N} wouldn't be better, rather than doing > addition in the

Re: [Qemu-devel] [PATCH v5 3/6] target: [tcg] Add generic translation framework

2017-01-10 Thread Richard Henderson
On 12/28/2016 08:28 AM, Lluís Vilanova wrote: +typedef enum DisasJumpType { +DJ_NEXT, +DJ_TOO_MANY, +DJ_TARGET, +} DisasJumpType; I wonder if enums like DJ_TARGET_{0..N} wouldn't be better, rather than doing addition in the target-specific names. +typedef struct

[Qemu-devel] [PATCH v5 3/6] target: [tcg] Add generic translation framework

2016-12-28 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- include/exec/gen-icount.h |2 include/exec/translate-all_template.h | 73 include/qom/cpu.h | 22 translate-all_template.h | 204 + 4