Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-25 Thread Kashyap Chamarthy
On Tue, Sep 25, 2018 at 11:15:05AM +0100, Peter Maydell wrote: > On 25 September 2018 at 09:58, Kashyap Chamarthy wrote: > > > Currently what I have is the 10 documents from the docs/ directory that > > are convereted to rST (some of them are already in QEMU Git); the below > > rendering is

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-25 Thread Peter Maydell
On 25 September 2018 at 09:58, Kashyap Chamarthy wrote: > Currently what I have is the 10 documents from the docs/ directory that > are convereted to rST (some of them are already in QEMU Git); the below > rendering is built from QEMU 3.0): >

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-25 Thread Peter Maydell
On 25 September 2018 at 10:40, Paolo Bonzini wrote: > However, we currently have the worst of both worlds. We have a manual > in Texinfo that almost nobody updates (except for the small parts that > are generated from .hx files in the code) and sparse documentation > written in a mix of rST,

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-25 Thread Paolo Bonzini
On 24/09/2018 20:44, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 24/09/2018 15:12, Peter Maydell wrote: >>> It got bumped by more important things >>> and also because somebody else said they were going to look at it, >>> and then it got bumped off *their* todo list by more

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-25 Thread Kashyap Chamarthy
On Mon, Sep 24, 2018 at 07:38:28PM +0200, Paolo Bonzini wrote: > On 24/09/2018 19:14, Peter Maydell wrote: > > On 24 September 2018 at 17:50, Paolo Bonzini wrote: > >> On 24/09/2018 15:12, Peter Maydell wrote: > >>> It got bumped by more important things > >>> and also because somebody else said

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-25 Thread Kashyap Chamarthy
On Mon, Sep 24, 2018 at 08:44:07PM +0200, Markus Armbruster wrote: [...] > Remind me, why would rST be an improvement? Relatively easy on the eye, more maintainable, active community around the Sphinx tooling / extensions, not extremely arcane syntax (besides some weird quirks), etc. Take a

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Markus Armbruster
Paolo Bonzini writes: > On 24/09/2018 15:12, Peter Maydell wrote: >> It got bumped by more important things >> and also because somebody else said they were going to look at it, >> and then it got bumped off *their* todo list by more important >> things :-)) > > I sense the force calling me...

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Paolo Bonzini
On 24/09/2018 19:14, Peter Maydell wrote: > On 24 September 2018 at 17:50, Paolo Bonzini wrote: >> On 24/09/2018 15:12, Peter Maydell wrote: >>> It got bumped by more important things >>> and also because somebody else said they were going to look at it, >>> and then it got bumped off *their*

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Peter Maydell
On 24 September 2018 at 17:50, Paolo Bonzini wrote: > On 24/09/2018 15:12, Peter Maydell wrote: >> It got bumped by more important things >> and also because somebody else said they were going to look at it, >> and then it got bumped off *their* todo list by more important >> things :-)) > > I

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Paolo Bonzini
On 24/09/2018 15:12, Peter Maydell wrote: > It got bumped by more important things > and also because somebody else said they were going to look at it, > and then it got bumped off *their* todo list by more important > things :-)) I sense the force calling me... Well, my plans were did not

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Peter Maydell
On 24 September 2018 at 14:02, Markus Armbruster wrote: > "Pavel Dovgalyuk" writes: >> This is a doxygen-style comment for automatic documentation generation. > > We don't generate documentation, yet. > > We do have many GTKDoc-style comments. Perhaps because we hope that if > we only add

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Markus Armbruster
"Pavel Dovgalyuk" writes: >> From: Markus Armbruster [mailto:arm...@redhat.com] >> Pavel Dovgalyuk writes: >> >> > This patch introduces replay_break qmp and hmp commands. >> > These commands allow stopping at the specified instruction. >> > It may be useful for debugging when there are some

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-24 Thread Pavel Dovgalyuk
> From: Markus Armbruster [mailto:arm...@redhat.com] > Pavel Dovgalyuk writes: > > > This patch introduces replay_break qmp and hmp commands. > > These commands allow stopping at the specified instruction. > > It may be useful for debugging when there are some known > > events that should be

Re: [Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-21 Thread Markus Armbruster
Pavel Dovgalyuk writes: > This patch introduces replay_break qmp and hmp commands. > These commands allow stopping at the specified instruction. > It may be useful for debugging when there are some known > events that should be investigated. > The commands have one argument - number of

[Qemu-devel] [PATCH v6 10/25] replay: introduce breakpoint at the specified step

2018-09-12 Thread Pavel Dovgalyuk
This patch introduces replay_break qmp and hmp commands. These commands allow stopping at the specified instruction. It may be useful for debugging when there are some known events that should be investigated. The commands have one argument - number of instructions executed since the start of the