[Qemu-devel] [PATCH v7 0/4] bugs fix for hpet

2013-10-16 Thread Liu Ping Fan
v7:
  use macro to define intcap in pc.h
  (as to 3/4 and 4/4, I am not sure about whether to merge them or not, so keep 
them separate)

v6:
  move the setting of intcap to board, and keep the init value as zero. (thanks 
for the discussion from Paolo and Michael)
  introduce an extra hpet property compat to tell PC version

v5:
  use stand compat property to fix hpet intcap on pc-q35, while on pc-piix, 
hard code intcap as IRQ2

v4:
  use stand compat property to fix hpet intcap

v3:
  change hpet interrupt capablity on board's demand



Liu Ping Fan (4):
  hpet: inverse polarity when pin above ISA_NUM_IRQS
  hpet: enable to entitle more irq pins for hpet
  PC: use qdev_xx to create hpet instead of sysbus_create_xx
  PC: differentiate hpet's interrupt capability on piix and q35

 hw/i386/pc.c | 23 ---
 hw/i386/pc_piix.c|  7 ++-
 hw/i386/pc_q35.c |  6 +-
 hw/timer/hpet.c  | 24 
 include/hw/i386/pc.h | 13 -
 5 files changed, 63 insertions(+), 10 deletions(-)

-- 
1.8.1.4




Re: [Qemu-devel] [PATCH v7 0/4] bugs fix for hpet

2013-10-16 Thread Michael S. Tsirkin
On Thu, Oct 17, 2013 at 11:16:01AM +0800, Liu Ping Fan wrote:
 v7:
   use macro to define intcap in pc.h
   (as to 3/4 and 4/4, I am not sure about whether to merge them or not, so 
 keep them separate)
 

Yes, please smash 2 3 and 4 together.
There's no need to waste time reviewing code that gets
deleted in the next patch.

 v6:
   move the setting of intcap to board, and keep the init value as zero. 
 (thanks for the discussion from Paolo and Michael)
   introduce an extra hpet property compat to tell PC version
 
 v5:
   use stand compat property to fix hpet intcap on pc-q35, while on pc-piix, 
 hard code intcap as IRQ2
 
 v4:
   use stand compat property to fix hpet intcap
 
 v3:
   change hpet interrupt capablity on board's demand
 
 
 
 Liu Ping Fan (4):
   hpet: inverse polarity when pin above ISA_NUM_IRQS
   hpet: enable to entitle more irq pins for hpet
   PC: use qdev_xx to create hpet instead of sysbus_create_xx
   PC: differentiate hpet's interrupt capability on piix and q35
 
  hw/i386/pc.c | 23 ---
  hw/i386/pc_piix.c|  7 ++-
  hw/i386/pc_q35.c |  6 +-
  hw/timer/hpet.c  | 24 
  include/hw/i386/pc.h | 13 -
  5 files changed, 63 insertions(+), 10 deletions(-)
 
 -- 
 1.8.1.4