Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently

2018-07-17 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 07/16/2018 04:52 PM, Eduardo Habkost wrote: > On Mon, Jul 16, 2018 at 10:20:09AM -0300, Philippe Mathieu-Daudé wrote: > [...] >>> +enum CacheType { >>> +DCACHE, >> >> I just noticed this clashes on mips host: > [...] >> In file included from

Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently

2018-07-16 Thread Eduardo Habkost
On Mon, Jul 16, 2018 at 10:20:09AM -0300, Philippe Mathieu-Daudé wrote: [...] > > +enum CacheType { > > +DCACHE, > > I just noticed this clashes on mips host: [...] > In file included from /usr/include/mips-linux-gnu/sys/cachectl.h:26:0, > from

Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently

2018-07-16 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 05/10/2018 05:41 PM, Babu Moger wrote: > From: Eduardo Habkost > > Instead of having a collection of macros that need to be used in > complex expressions to build CPUID data, define a CPUCacheInfo > struct that can hold information about a given cache. Helper > functions will

Re: [Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently

2018-05-11 Thread Eduardo Habkost
On Thu, May 10, 2018 at 03:41:41PM -0500, Babu Moger wrote: > From: Eduardo Habkost > > Instead of having a collection of macros that need to be used in > complex expressions to build CPUID data, define a CPUCacheInfo > struct that can hold information about a given cache.

[Qemu-devel] [PATCH v8 1/8] i386: Helpers to encode cache information consistently

2018-05-10 Thread Babu Moger
From: Eduardo Habkost Instead of having a collection of macros that need to be used in complex expressions to build CPUID data, define a CPUCacheInfo struct that can hold information about a given cache. Helper functions will take a CPUCacheInfo struct as input to encode