Re: [Qemu-devel] [PATCH v8 10/28] sev/i386: add command to initialize the memory encryption context

2018-02-12 Thread Eduardo Habkost
On Mon, Feb 12, 2018 at 09:36:57AM -0600, Brijesh Singh wrote: [...] > +#define SEV_FW_MAX_ERROR 0x17 > + > +static const char *const sev_fw_errlist[] = { This requires anybody reading the code to manually count the number of items on the array to be sure fw_error_to_str() is safe. What abou

[Qemu-devel] [PATCH v8 10/28] sev/i386: add command to initialize the memory encryption context

2018-02-12 Thread Brijesh Singh
When memory encryption is enabled, KVM_SEV_INIT command is used to initialize the platform. The command loads the SEV related persistent data from non-volatile storage and initializes the platform context. This command should be first issued before invoking any other guest commands provided by the