Re: [Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-14 Thread Eric Blake
On 02/13/2018 11:18 AM, Viktor Mihajlovski wrote: The s390 CPU state can be retrieved without interrupting the VM execution. Extendend the CpuInfoFast union with architecture s/Extendend/Extend/ specific data and an implementation for s390. Return data looks like this: [

Re: [Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-14 Thread Cornelia Huck
On Wed, 14 Feb 2018 09:15:23 -0600 Eric Blake wrote: > On 02/14/2018 04:15 AM, Cornelia Huck wrote: > > On Tue, 13 Feb 2018 18:18:48 +0100 > > Viktor Mihajlovski wrote: > > > > >> A suggestion was made on the mailing list to enhance the QAPI >

Re: [Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-14 Thread Eric Blake
On 02/14/2018 09:50 AM, Viktor Mihajlovski wrote: I'd like to know first what libvirt plans to do -- no sense in starting deprecation if we're still stuck with it for a while. FWIW, I'm currently preparing libvirt patches to use query-cpus-fast if available. I wouldn't see why it would take

Re: [Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-14 Thread Viktor Mihajlovski
On 14.02.2018 16:27, Cornelia Huck wrote: > On Wed, 14 Feb 2018 09:15:23 -0600 > Eric Blake wrote: > >> On 02/14/2018 04:15 AM, Cornelia Huck wrote: >>> On Tue, 13 Feb 2018 18:18:48 +0100 >>> Viktor Mihajlovski wrote: >>> >> A suggestion

Re: [Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-14 Thread Eric Blake
On 02/14/2018 04:15 AM, Cornelia Huck wrote: On Tue, 13 Feb 2018 18:18:48 +0100 Viktor Mihajlovski wrote: A suggestion was made on the mailing list to enhance the QAPI code generation to support two layers of unions. This would allow to specify the common fields

Re: [Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-14 Thread Cornelia Huck
On Tue, 13 Feb 2018 18:18:48 +0100 Viktor Mihajlovski wrote: > The s390 CPU state can be retrieved without interrupting the > VM execution. Extendend the CpuInfoFast union with architecture > specific data and an implementation for s390. > > Return data looks like

[Qemu-devel] [PATCHv2 3/3] qmp: add architecture specific cpu data for query-cpus-fast

2018-02-13 Thread Viktor Mihajlovski
The s390 CPU state can be retrieved without interrupting the VM execution. Extendend the CpuInfoFast union with architecture specific data and an implementation for s390. Return data looks like this: [ {"thread-id":64301,"props":{"core-id":0}, "arch":"s390","cpu-state":"operating",