Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2018-03-23 Thread Eduardo Otubo
On 16/03/2018 - 11:46:57, Thomas Huth wrote: > On 27.11.2017 09:40, Eduardo Otubo wrote: > > On Fri, Nov 24, 2017 at 06:44:59PM +0100, Thomas Huth wrote: > >> Hi Eduardo, > >> > >> On 24.11.2017 14:46, Eduardo Otubo wrote: > >>> v3: > >>> * Removed all unecessary local_err > >>> * Change return

Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2018-03-16 Thread Thomas Huth
On 27.11.2017 09:40, Eduardo Otubo wrote: > On Fri, Nov 24, 2017 at 06:44:59PM +0100, Thomas Huth wrote: >> Hi Eduardo, >> >> On 24.11.2017 14:46, Eduardo Otubo wrote: >>> v3: >>> * Removed all unecessary local_err >>> * Change return of isa_bus_dma() and DMA_init() from void to int8_t, >>>

Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2017-11-27 Thread Eduardo Otubo
On Fri, Nov 24, 2017 at 06:44:59PM +0100, Thomas Huth wrote: > Hi Eduardo, > > On 24.11.2017 14:46, Eduardo Otubo wrote: > > v3: > > * Removed all unecessary local_err > > * Change return of isa_bus_dma() and DMA_init() from void to int8_t, > >returning -EBUSY on error and 0 on success > >

Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2017-11-24 Thread Thomas Huth
Hi Eduardo, On 24.11.2017 14:46, Eduardo Otubo wrote: > v3: > * Removed all unecessary local_err > * Change return of isa_bus_dma() and DMA_init() from void to int8_t, >returning -EBUSY on error and 0 on success > * Added qdev_cleanup_nofail() in case isa_bus_dma() returns error. The >

Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2017-11-24 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device Type: series Message-id

[Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2017-11-24 Thread Eduardo Otubo
v3: * Removed all unecessary local_err * Change return of isa_bus_dma() and DMA_init() from void to int8_t, returning -EBUSY on error and 0 on success * Added qdev_cleanup_nofail() in case isa_bus_dma() returns error. The cleanup looks safe, but please review if I didn't miss any detail