Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-03 Thread Jason Wang
Michael S. Tsirkin writes: > On Thu, Dec 02, 2010 at 10:19:55PM +0800, Jason Wang wrote: > > Michael S. Tsirkin writes: > > > On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: > > > > Michael S. Tsirkin writes: > > > > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote:

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-03 Thread Kevin Wolf
Am 01.12.2010 06:59, schrieb Michael S. Tsirkin: > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: >> Michael S. Tsirkin writes: >> > Avoid sending out packets, and modifying >> > device state, when VM is stopped. >> > Add assert statements to verify this does not happen. >> > >>

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-03 Thread Kevin Wolf
Am 02.12.2010 19:27, schrieb Michael S. Tsirkin: > On Thu, Dec 02, 2010 at 10:19:55PM +0800, Jason Wang wrote: >> Michael S. Tsirkin writes: >> > On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: >> > > Michael S. Tsirkin writes: >> > > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jaso

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 10:19:55PM +0800, Jason Wang wrote: > Michael S. Tsirkin writes: > > On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: > > > Michael S. Tsirkin writes: > > > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > > > > > Michael S. Tsirkin writes: >

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-02 Thread Jason Wang
Michael S. Tsirkin writes: > On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: > > Michael S. Tsirkin writes: > > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > > > > Michael S. Tsirkin writes: > > > > > Avoid sending out packets, and modifying > > > > > devic

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 10:19:55PM +0800, Jason Wang wrote: > Michael S. Tsirkin writes: > > On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: > > > Michael S. Tsirkin writes: > > > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > > > > > Michael S. Tsirkin writes: >

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: > Michael S. Tsirkin writes: > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > > > Michael S. Tsirkin writes: > > > > Avoid sending out packets, and modifying > > > > device state, when VM is stopped. > > > > Add as

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-02 Thread Michael S. Tsirkin
On Thu, Dec 02, 2010 at 08:56:30PM +0800, Jason Wang wrote: > Michael S. Tsirkin writes: > > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > > > Michael S. Tsirkin writes: > > > > Avoid sending out packets, and modifying > > > > device state, when VM is stopped. > > > > Add as

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-02 Thread Jason Wang
Michael S. Tsirkin writes: > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > > Michael S. Tsirkin writes: > > > Avoid sending out packets, and modifying > > > device state, when VM is stopped. > > > Add assert statements to verify this does not happen. > > > > > > Avoid s

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-01 Thread Michael S. Tsirkin
On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > Michael S. Tsirkin writes: > > Avoid sending out packets, and modifying > > device state, when VM is stopped. > > Add assert statements to verify this does not happen. > > > > Avoid scheduling bh when vhost-net is started. > > >

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-01 Thread Jason Wang
Michael S. Tsirkin writes: > On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > > Michael S. Tsirkin writes: > > > Avoid sending out packets, and modifying > > > device state, when VM is stopped. > > > Add assert statements to verify this does not happen. > > > > > > Avoid s

Re: [Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-01 Thread Michael S. Tsirkin
On Wed, Dec 01, 2010 at 01:45:09PM +0800, Jason Wang wrote: > Michael S. Tsirkin writes: > > Avoid sending out packets, and modifying > > device state, when VM is stopped. > > Add assert statements to verify this does not happen. > > > > Avoid scheduling bh when vhost-net is started. > > >

[Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-12-01 Thread Jason Wang
Michael S. Tsirkin writes: > Avoid sending out packets, and modifying > device state, when VM is stopped. > Add assert statements to verify this does not happen. > > Avoid scheduling bh when vhost-net is started. > > Stop bh when driver disabled bus mastering > (we must not access memory

[Qemu-devel] [PATCHv3 4/6] virtio-net: stop/start bh when appropriate

2010-11-29 Thread Michael S. Tsirkin
Avoid sending out packets, and modifying device state, when VM is stopped. Add assert statements to verify this does not happen. Avoid scheduling bh when vhost-net is started. Stop bh when driver disabled bus mastering (we must not access memory after this). Signed-off-by: Michael S. Tsirkin -