Re: [Qemu-devel] [PATCHv4 2/4] qmp: add query-cpus-fast

2018-02-16 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 02/16/2018 08:49 AM, Viktor Mihajlovski wrote: > > > > > > > The HMP changes are non-trivial compared to v3, so I might have dropped > > > all R-b and Acked-by to ensure they are looked at again. > > > > > > In fact,... > > > > > > > > - > > > > -  

Re: [Qemu-devel] [PATCHv4 2/4] qmp: add query-cpus-fast

2018-02-16 Thread Eric Blake
On 02/16/2018 08:49 AM, Viktor Mihajlovski wrote: The HMP changes are non-trivial compared to v3, so I might have dropped all R-b and Acked-by to ensure they are looked at again. In fact,... - -    if (cpu->value->CPU == monitor_get_cpu_index()) { -    active = '*'; -    }

Re: [Qemu-devel] [PATCHv4 2/4] qmp: add query-cpus-fast

2018-02-16 Thread Viktor Mihajlovski
On 16.02.2018 15:03, Eric Blake wrote: > On 02/16/2018 06:04 AM, Viktor Mihajlovski wrote: >> From: Luiz Capitulino >> >> The query-cpus command has an extremely serious side effect: >> it always interrupts all running vCPUs so that they can run >> ioctl calls. This can

Re: [Qemu-devel] [PATCHv4 2/4] qmp: add query-cpus-fast

2018-02-16 Thread Eric Blake
On 02/16/2018 06:04 AM, Viktor Mihajlovski wrote: From: Luiz Capitulino The query-cpus command has an extremely serious side effect: it always interrupts all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for some

[Qemu-devel] [PATCHv4 2/4] qmp: add query-cpus-fast

2018-02-16 Thread Viktor Mihajlovski
From: Luiz Capitulino The query-cpus command has an extremely serious side effect: it always interrupts all running vCPUs so that they can run ioctl calls. This can cause a huge performance degradation for some workloads. And most of the information retrieved by the ioctl