Re: [Qemu-devel] [PULL 01/17] migration: remove register_savevm()

2017-06-07 Thread Juan Quintela
Peter Maydell wrote: > On 6 June 2017 at 03:51, David Gibson wrote: >> From: Laurent Vivier >> >> We can replace the four remaining calls of register_savevm() by >> calls to register_savevm_live(). So we can remove the

Re: [Qemu-devel] [PULL 01/17] migration: remove register_savevm()

2017-06-06 Thread Paolo Bonzini
On 06/06/2017 19:49, Peter Maydell wrote: > Things that would be interesting to explain/document: > * what is special about vmxnet3 that makes it the only pci device >that needs to use this rather than having a vmstate struct? Nothing, it should be replaced by VMSTATE_MSIX (at the cost of

Re: [Qemu-devel] [PULL 01/17] migration: remove register_savevm()

2017-06-06 Thread Peter Maydell
On 6 June 2017 at 03:51, David Gibson wrote: > From: Laurent Vivier > > We can replace the four remaining calls of register_savevm() by > calls to register_savevm_live(). So we can remove the function and > as we don't allocate anymore the ops

[Qemu-devel] [PULL 01/17] migration: remove register_savevm()

2017-06-05 Thread David Gibson
From: Laurent Vivier We can replace the four remaining calls of register_savevm() by calls to register_savevm_live(). So we can remove the function and as we don't allocate anymore the ops pointer with g_new0() we don't have to free it then. Signed-off-by: Laurent Vivier