Re: [Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

2018-02-12 Thread Max Reitz
On 2018-02-12 12:33, Christian Borntraeger wrote: > Adding Max and Alberto, > > I think the issue is that on s390 you cannot add a floppy Thanks for letting me know. I don't know why I resorted to floppy when virtio would have worked (in this test) just as well... Max signature.asc Descripti

Re: [Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

2018-02-12 Thread Christian Borntraeger
Adding Max and Alberto, I think the issue is that on s390 you cannot add a floppy On 02/12/2018 12:16 PM, Christian Borntraeger wrote: > > On 01/23/2018 03:01 PM, Kevin Wolf wrote: >> From: Max Reitz >> >> In some cases, these commands still use the deprecated @device >> parameter. Fix that s

Re: [Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

2018-02-12 Thread Christian Borntraeger
On 01/23/2018 03:01 PM, Kevin Wolf wrote: > From: Max Reitz > > In some cases, these commands still use the deprecated @device > parameter. Fix that so we can later drop that parameter from their > interface. > > Signed-off-by: Max Reitz > Message-id: 20171110224302.14424-2-mre...@redhat.com

[Qemu-devel] [PULL 06/29] iotests: Make BD-{remove, insert}-medium use @id

2018-01-23 Thread Kevin Wolf
From: Max Reitz In some cases, these commands still use the deprecated @device parameter. Fix that so we can later drop that parameter from their interface. Signed-off-by: Max Reitz Message-id: 20171110224302.14424-2-mre...@redhat.com Reviewed-by: Alberto Garcia Signed-off-by: Max Reitz ---