Re: [Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a

2017-11-15 Thread Jason Wang
On 2017年11月15日 14:43, Stefan Weil wrote: Hi, I currently think that this patch is wrong and should be reverted. It fixes a certain use case by hacking the PCI device id, but does not model the way how that device id is set on the real hardware correctly. As far as I know, all i82559 have a

Re: [Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a

2017-11-14 Thread Stefan Weil
Hi, I currently think that this patch is wrong and should be reverted. It fixes a certain use case by hacking the PCI device id, but does not model the way how that device id is set on the real hardware correctly. As far as I know, all i82559 have a default PCI device id of 0x1229. It can be

[Qemu-devel] [PULL 7/8] Add new PCI ID for i82559a

2017-11-13 Thread Jason Wang
From: Mike Nawrocki Adds a new PCI ID for the i82559a (0x8086 0x1030) interface. The "x-use-alt-device-id" property controls whether this new ID is to be used, and is true by default, and set to false in a compat entry. Signed-off-by: Mike Nawrocki