Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-12 Thread Daniel P . Berrangé
On Mon, Feb 12, 2018 at 01:42:11PM +0100, Kevin Wolf wrote: > Am 12.02.2018 um 11:02 hat Daniel P. Berrangé geschrieben: > > On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote: > > > On 10/02/2018 00:07, John Snow wrote: > > > >> +/* Early check to avoid creating target */ > > > >> +

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-12 Thread Kevin Wolf
Am 12.02.2018 um 11:02 hat Daniel P. Berrangé geschrieben: > On Mon, Feb 12, 2018 at 10:58:31AM +0100, Paolo Bonzini wrote: > > On 10/02/2018 00:07, John Snow wrote: > > >> +/* Early check to avoid creating target */ > > >> +if (bdrv_op_is_blocked(bs, BLOCK_OP_TYPE_MIRROR_SOURCE, errp)) { >

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-09 Thread Kevin Wolf
Am 07.02.2018 um 17:29 hat Paolo Bonzini geschrieben: > Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, > it is checked a bit late and the result is that the target is > created even if drive-mirror subsequently fails. Add an early > check to avoid this. > > Signed-off-by: Paolo

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-08 Thread Alberto Garcia
On Wed 07 Feb 2018 05:29:20 PM CET, Paolo Bonzini wrote: > Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, > it is checked a bit late and the result is that the target is > created even if drive-mirror subsequently fails. Add an early > check to avoid this. > > Signed-off-by: Pao

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-08 Thread Paolo Bonzini
On 08/02/2018 11:10, Alberto Garcia wrote: > On Wed 07 Feb 2018 05:29:20 PM CET, Paolo Bonzini wrote: >> Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, >> it is checked a bit late and the result is that the target is >> created even if drive-mirror subsequently fails. Add an ear

Re: [Qemu-devel] [Qemu-block] [PATCH] block: early check for blockers on drive-mirror

2018-02-08 Thread Alberto Garcia
On Wed 07 Feb 2018 05:29:20 PM CET, Paolo Bonzini wrote: > Even if an op blocker is present for BLOCK_OP_TYPE_MIRROR_SOURCE, > it is checked a bit late and the result is that the target is > created even if drive-mirror subsequently fails. Add an early > check to avoid this. > > Signed-off-by: Pao