Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

On Thu, Nov 17, Olaf Hering wrote: > Looking at current master, BLKIF_OP_DISCARD is indeed broken. The values > passed from the guest are u64 and get stashed into signed values. I will > add a loop to repeatedly call blk_aio_pdiscard with small chunks of > BDRV_REQUEST_MAX_SECTORS. I have not

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

On Fri, May 06, Max Reitz wrote: > On 01.04.2016 19:49, Olaf Hering wrote: > > On Fri, Apr 01, Max Reitz wrote: > > > >> In any case, do you have a test case where a guest was able to submit a > >> request that led to the overflow error you described in the commit message? > > > > mkfs -t ext4

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

On 01.04.2016 19:49, Olaf Hering wrote: > On Fri, Apr 01, Max Reitz wrote: > >> In any case, do you have a test case where a guest was able to submit a >> request that led to the overflow error you described in the commit message? > > mkfs -t ext4 /dev/sdb1 in a xen guest with qcow2 as backing

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

On Fri, Apr 01, Max Reitz wrote: > In any case, do you have a test case where a guest was able to submit a > request that led to the overflow error you described in the commit message? mkfs -t ext4 /dev/sdb1 in a xen guest with qcow2 as backing device. When I added discard support to libxl I

Re: [Qemu-devel] [Qemu-block] [PATCH] block: split large discard requests from block frontend

On 01.04.2016 14:22, Olaf Hering wrote: > Large discard requests lead to sign expansion errors in qemu. > Since there is no API to tell a guest about the limitations qmeu > has to split a large request itself. > > Signed-off-by: Olaf Hering > Cc: Stefan Hajnoczi