Re: [Qemu-devel] [Qemu-block] [PATCH 1/7] util: Add UUID API

2016-08-08 Thread Fam Zheng
On Thu, 08/04 11:33, Jeff Cody wrote: > It makes sense to represent the uuid internally as a struct with the octet > groupings of uint32_t, uint16_t, etc.., for endianness: BTW I'm not sure it's worth to add that internal representation. libuuid uses local endianness when generating and setting

Re: [Qemu-devel] [Qemu-block] [PATCH 1/7] util: Add UUID API

2016-08-07 Thread Fam Zheng
On Thu, 08/04 11:33, Jeff Cody wrote: > > +void qemu_uuid_generate(qemu_uuid_t out) > > +{ > > +/* Version 4 UUID, RFC4122 4.4. */ > > +QEMU_BUILD_BUG_ON(sizeof(qemu_uuid_t) != 16); > > +*((guint32 *)out + 0) = g_random_int(); > > +*((guint32 *)out + 1) = g_random_int(); > > +

Re: [Qemu-devel] [Qemu-block] [PATCH 1/7] util: Add UUID API

2016-08-04 Thread Jeff Cody
On Tue, Aug 02, 2016 at 05:18:32PM +0800, Fam Zheng wrote: > A number of different places across the code base use CONFIG_UUID. Some > of them are soft dependency, some are not built if libuuid is not > available, some come with dummy fallback, some throws runtime error. > > It is hard to