Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-22 Thread G 3
On Jun 22, 2017, at 3:25 AM, Peter Maydell wrote: On 22 June 2017 at 03:54, G 3 wrote: The advantage a test image would have is the user doesn't have to worry about compiling a test using a cross compiler. Everything the user would need to test QEMU is already

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-22 Thread Peter Maydell
On 22 June 2017 at 03:54, G 3 wrote: > The advantage a test image would have is the user doesn't have to worry > about compiling a test using a cross compiler. Everything the user would > need to test QEMU is already inside the image file (hopefully). > > Is the setup

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-21 Thread G 3
On Jun 21, 2017, at 12:28 PM, Peter Maydell wrote: On 21 June 2017 at 17:27, G 3 wrote: On Jun 21, 2017, at 12:20 PM, Peter Maydell wrote: We don't yet have any mechanism for having tests that need to be compiled for the target architecture, do we? I don't know

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-21 Thread G 3
On Jun 21, 2017, at 12:20 PM, Peter Maydell wrote: On 21 June 2017 at 17:14, Philippe Mathieu-Daudé wrote: do you think you can add your test as a qtest, to run it with check-qtest? We don't yet have any mechanism for having tests that need to be compiled for the target

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-21 Thread G 3
On Jun 21, 2017, at 12:14 PM, Philippe Mathieu-Daudé wrote: Hi John, On 05/09/2017 10:58 AM, G 3 wrote: On May 9, 2017, at 5:55 AM, BALATON Zoltan wrote: On Tue, 9 May 2017, Aurelien Jarno wrote: | main.c: In function 'print_fpscr_settings': | main.c:73:26: warning: suggest parentheses

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-21 Thread Alex Bennée
Peter Maydell writes: > On 21 June 2017 at 17:14, Philippe Mathieu-Daudé wrote: >> do you think you can add your test as a qtest, to run it with check-qtest? > > We don't yet have any mechanism for having tests that need to > be compiled for the

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-21 Thread Peter Maydell
On 21 June 2017 at 17:27, G 3 wrote: > On Jun 21, 2017, at 12:20 PM, Peter Maydell wrote: >> We don't yet have any mechanism for having tests that need to >> be compiled for the target architecture, do we? > > > I don't know about that but I do know we have image files

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-21 Thread Peter Maydell
On 21 June 2017 at 17:14, Philippe Mathieu-Daudé wrote: > do you think you can add your test as a qtest, to run it with check-qtest? We don't yet have any mechanism for having tests that need to be compiled for the target architecture, do we? thanks -- PMM

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-06-21 Thread Philippe Mathieu-Daudé
Hi John, On 05/09/2017 10:58 AM, G 3 wrote: On May 9, 2017, at 5:55 AM, BALATON Zoltan wrote: On Tue, 9 May 2017, Aurelien Jarno wrote: | main.c: In function 'print_fpscr_settings': | main.c:73:26: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] |

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-05-09 Thread G 3
On May 9, 2017, at 5:55 AM, BALATON Zoltan wrote: On Tue, 9 May 2017, Aurelien Jarno wrote: | main.c: In function 'print_fpscr_settings': | main.c:73:26: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] | if ((fpscr >> i) & 0x1 == 1) { |

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

2017-05-09 Thread BALATON Zoltan
On Tue, 9 May 2017, Aurelien Jarno wrote: | main.c: In function 'print_fpscr_settings': | main.c:73:26: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] | if ((fpscr >> i) & 0x1 == 1) { | ^ Actually the compiler is correct