Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-12 Thread Michael Tokarev 
05.06.2013 00:23, Alon Levy wrote:

 [PATCH 1/5] oslib-posix: add qemu_pipe_non_block
 [PATCH 2/5] use qemu_pipe_non_block
 [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths
 [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference
 [PATCH 5/5] libcacard/vscclient.c: fix use of uninitialized variable

So, what happened with this series?

From the above 5 patches, only 3/5 (leakage of socket on error paths)
is ready to be applied.  Should I apply it now, or wait for the
respin of whole series?  (Or both?)

Thanks,

/mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-12 Thread Alon Levy 
 05.06.2013 00:23, Alon Levy wrote:
 
  [PATCH 1/5] oslib-posix: add qemu_pipe_non_block
  [PATCH 2/5] use qemu_pipe_non_block
  [PATCH 3/5] libcacard/vscclient: fix leakage of socket on error paths
  [PATCH 4/5] libcacard/vreader.c: fix possible NULL dereference
  [PATCH 5/5] libcacard/vscclient.c: fix use of uninitialized variable
 
 So, what happened with this series?

I still plan to do it, but didn't get to it yet.

 
 From the above 5 patches, only 3/5 (leakage of socket on error paths)
 is ready to be applied.  Should I apply it now, or wait for the
 respin of whole series?  (Or both?)

I'll be happy if you do. (Both don't actually make sense :)

 
 Thanks,
 
 /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-05 Thread Michael Tokarev 
05.06.2013 00:23, Alon Levy wrote:
 Used by the followin patch.
 
 +int qemu_pipe_non_block(int pipefd[2]);

A nitpick.  I'd name it qemu_pipe_nonblock(), like O_NONBLOCK
is named, but that may be just me.

Thanks,

/mjt