Re: [Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-14 Thread Laurent Vivier
On 14/06/2019 09:49, Amit Shah wrote: > On Thu, 2019-06-13 at 10:53 +0200, Laurent Vivier wrote: >> On 12/06/2019 09:03, Amit Shah wrote: >>> On Tue, 2019-06-11 at 19:20 +0200, Laurent Vivier wrote: The virtio-rng linux driver can be stuck in virtio_read() on a

Re: [Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-14 Thread Amit Shah
On Thu, 2019-06-13 at 10:53 +0200, Laurent Vivier wrote: > On 12/06/2019 09:03, Amit Shah wrote: > > On Tue, 2019-06-11 at 19:20 +0200, Laurent Vivier wrote: > > > The virtio-rng linux driver can be stuck in virtio_read() on a > > > wait_for_completion_killable() call if the virtio-rng device in >

Re: [Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-13 Thread Laurent Vivier
On 12/06/2019 09:03, Amit Shah wrote: > On Tue, 2019-06-11 at 19:20 +0200, Laurent Vivier wrote: >> The virtio-rng linux driver can be stuck in virtio_read() on a >> wait_for_completion_killable() call if the virtio-rng device in QEMU >> doesn't provide data. >> >> It's a problem, because

Re: [Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-12 Thread Amit Shah
On Tue, 2019-06-11 at 19:20 +0200, Laurent Vivier wrote: > The virtio-rng linux driver can be stuck in virtio_read() on a > wait_for_completion_killable() call if the virtio-rng device in QEMU > doesn't provide data. > > It's a problem, because virtio_read() is called from rng_get_data() > with >

[Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-11 Thread Laurent Vivier
The virtio-rng linux driver can be stuck in virtio_read() on a wait_for_completion_killable() call if the virtio-rng device in QEMU doesn't provide data. It's a problem, because virtio_read() is called from rng_get_data() with reading_mutex() held. The same mutex is taken by