Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Michael S. Tsirkin
On Fri, Dec 07, 2018 at 04:46:29PM +, Daniel P. Berrangé wrote: > I'm not convinced it is useful enough to justify playing games in qdev > with dynamically hiding devices. This adds complexity to the code which > will make it harder to maintain and debug at runtime. I actually think a hidden d

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 10:06:18AM +, Daniel P. Berrangé wrote: > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > > From: Sameeh Jubran > > > > > > > >

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Roman Kagan
On Thu, Dec 06, 2018 at 10:06:18AM +, Daniel P. Berrangé wrote: > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > > From: Sameeh Jubran > > > > > > > >

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Daniel P . Berrangé
On Fri, Dec 07, 2018 at 02:36:07PM -0200, Eduardo Habkost wrote: > On Thu, Dec 06, 2018 at 10:06:18AM +, Daniel P. Berrangé wrote: > > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > > On Thu, Oct 25, 2018 at 05:06:29PM

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-07 Thread Eduardo Habkost
On Thu, Dec 06, 2018 at 10:06:18AM +, Daniel P. Berrangé wrote: > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > > From: Sameeh Jubran > > > > > > > >

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-06 Thread Daniel P . Berrangé
On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > From: Sameeh Jubran > > > > > > Hi all, > > > > > > Background: > > > > > > There has been a few attempts to

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-06 Thread Daniel P . Berrangé
On Wed, Dec 05, 2018 at 03:57:14PM -0500, Michael S. Tsirkin wrote: > On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > > > > > Unless I'm mis-reading the patches, it looks like the VFIO device always > > > has > > > to be avail

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-05 Thread Michael S. Tsirkin
On Wed, Dec 05, 2018 at 02:44:38PM -0600, Michael Roth wrote: > > So how important is it that setting F_STANDBY cap doesn't break older > > guests? If the idea is to support live migration with VFs then aren't > > we still dead in the water if the guest boots okay but doesn't have > > the requisite

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-05 Thread Michael S. Tsirkin
On Wed, Dec 05, 2018 at 02:24:32PM -0600, Michael Roth wrote: > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > From: Sameeh Jubran > > > > > > Hi all, > > > > > > Background: > > > > > > There has been a few attempts to

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-05 Thread Michael Roth
Quoting Michael Roth (2018-12-05 14:24:32) > Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > > From: Sameeh Jubran > > > > > > Hi all, > > > > > > Background: > > > > > > There has been a few attempts to implement the stand

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-05 Thread Michael Roth
Quoting Daniel P. Berrangé (2018-12-05 11:18:18) > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > From: Sameeh Jubran > > > > Hi all, > > > > Background: > > > > There has been a few attempts to implement the standby feature for vfio > > assigned devices which aims to enable

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-05 Thread Michael S. Tsirkin
On Wed, Dec 05, 2018 at 05:18:18PM +, Daniel P. Berrangé wrote: > On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > > From: Sameeh Jubran > > > > Hi all, > > > > Background: > > > > There has been a few attempts to implement the standby feature for vfio > > assigned devices w

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-05 Thread Daniel P . Berrangé
On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > From: Sameeh Jubran > > Hi all, > > Background: > > There has been a few attempts to implement the standby feature for vfio > assigned devices which aims to enable the migration of such devices. This > is another attempt. > > The

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-12-05 Thread Michael Roth
Quoting Sameeh Jubran (2018-10-25 13:01:10) > On Thu, Oct 25, 2018 at 5:06 PM Sameeh Jubran wrote: > > > > From: Sameeh Jubran > > > > Hi all, > > > > Background: > > > > There has been a few attempts to implement the standby feature for vfio > > assigned devices which aims to enable the migratio

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-10-25 Thread Michael S. Tsirkin
On Thu, Oct 25, 2018 at 05:06:29PM +0300, Sameeh Jubran wrote: > From: Sameeh Jubran > > Hi all, > > Background: > > There has been a few attempts to implement the standby feature for vfio > assigned devices which aims to enable the migration of such devices. This > is another attempt. > > The

Re: [Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-10-25 Thread Sameeh Jubran
On Thu, Oct 25, 2018 at 5:06 PM Sameeh Jubran wrote: > > From: Sameeh Jubran > > Hi all, > > Background: > > There has been a few attempts to implement the standby feature for vfio > assigned devices which aims to enable the migration of such devices. This > is another attempt. > > The series imp

[Qemu-devel] [RFC 0/2] Attempt to implement the standby feature for assigned network devices

2018-10-25 Thread Sameeh Jubran
From: Sameeh Jubran Hi all, Background: There has been a few attempts to implement the standby feature for vfio assigned devices which aims to enable the migration of such devices. This is another attempt. The series implements an infrastructure for hiding devices from the bus upon boot. What