Re: [Qemu-devel] [RFC 06/48] tcg: use QHT for helper_table

2018-11-14 Thread Emilio G. Cota
On Wed, Nov 14, 2018 at 16:11:35 +, Alex Bennée wrote: > > Emilio G. Cota writes: (snip) > I needed to do this: > > modified tcg/tcg.c > @@ -884,7 +884,7 @@ static TCGTemp *tcg_global_reg_new_internal(TCGContext > *s, TCGType type, > > static inline uint32_t tcg_helper_func_hash(const

Re: [Qemu-devel] [RFC 06/48] tcg: use QHT for helper_table

2018-11-14 Thread Emilio G. Cota
On Wed, Nov 14, 2018 at 14:41:53 +, Alex Bennée wrote: > Emilio G. Cota writes: (snip) > > -static GHashTable *helper_table; > > +static struct qht helper_table; > > +static bool helper_table_inited; > > Having a flag for initialisation seems a little excessive considering > we've moved that

Re: [Qemu-devel] [RFC 06/48] tcg: use QHT for helper_table

2018-11-14 Thread Alex Bennée
Emilio G. Cota writes: > This will allow us to add TCG helpers at run-time. > > While at it, rename tcg_find_helper to tcg_helper_find for consistency > with the added tcg_helper_foo functions. > > Signed-off-by: Emilio G. Cota > --- > tcg/tcg.c | 59

Re: [Qemu-devel] [RFC 06/48] tcg: use QHT for helper_table

2018-11-14 Thread Alex Bennée
Emilio G. Cota writes: > This will allow us to add TCG helpers at run-time. > > While at it, rename tcg_find_helper to tcg_helper_find for consistency > with the added tcg_helper_foo functions. > > Signed-off-by: Emilio G. Cota > --- > tcg/tcg.c | 59

[Qemu-devel] [RFC 06/48] tcg: use QHT for helper_table

2018-10-25 Thread Emilio G. Cota
This will allow us to add TCG helpers at run-time. While at it, rename tcg_find_helper to tcg_helper_find for consistency with the added tcg_helper_foo functions. Signed-off-by: Emilio G. Cota --- tcg/tcg.c | 59 +-- 1 file changed, 49